planner/core: update missing virtual columns in update and insert (#58401)

[ti-chi-bot]

This is an automated cherry-pick of #58401

What problem does this PR solve?

Issue Number: close #58400

Problem Summary:

In #58494, we fixed a problem related to virtual columns. But we haven't completely fixed it yet. There still have problems with virtual columns.

For Update:

In update statements, virtual columns will be added into UpdateLists if their dependent columns have changed. #55829 has fixed nested generated column.

tidb/pkg/planner/core/logical_plan_builder.go

Lines 5826 to 5837 in f2db9c4

	// check if the column is modified
	dependentColumns := expression.ExtractDependentColumns(newExpr)
	var isModified bool
	for _, col := range dependentColumns {
	if dependentColumnsModified[col.UniqueID] {
	isModified = true
	break
	}
	}
	if isModified {
	dependentColumnsModified[col.UniqueID] = true
	}

However, we still ignore the columns with OnUpdateNow flag when checking dependency. Since these columns may be updated in the execution stage too.

For Insert:

For SQL like INSERT INTO ... ON DUPLICATE KEY UPDATE ..., only virtual columns that directly depend on the assignments after UPDATE will be updated. Take the table in #58400 as example:

CREATE TABLE tmv (
  J1 json, J2 json GENERATED ALWAYS AS (j1) VIRTUAL,
  UNIQUE KEY i1 ((cast(j1 as signed array))),
  KEY i2 ((cast(j2 as signed array)))
);

INSERT INTO tmv SET j1 = '[1]' ON DUPLICATE KEY UPDATE j1 = '[2]';

The dependencies of each column are listed below. Only j2 and _V$_i1_0 are updated since they depends on j1. We should handle it the same way as what we do in #55829.

j2 <-- j1
_V$_i1_0 <-- j1
_V$_i2_0 <-- j2

What changed and how does it work?

In summary, when extracting generated columns, we have to consider both chain dependencies and on-update-now flag too.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[ti-chi-bot]

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

1. It must be approved by the approvers firstly.
2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign elsa0520 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS
• pkg/planner/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release-8.5@e4e814f). Learn more about missing BASE report.

Additional details and impacted files

@@               Coverage Diff                @@
##             release-8.5     #64752   +/-   ##
================================================
  Coverage               ?   48.6535%           
================================================
  Files                  ?       1559           
  Lines                  ?     440344           
  Branches               ?          0           
================================================
  Hits                   ?     214243           
  Misses                 ?     207018           
  Partials               ?      19083           

Flag	Coverage Δ
integration	48.6535% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	∅ <0.0000%> (?)
parser	∅ <0.0000%> (?)
br	22.8520% <0.0000%> (?)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[ti-chi-bot]

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
idc-jenkins-ci-tidb/check_dev_2	aad2fd7	link	true	/test check-dev2
idc-jenkins-ci-tidb/unit-test	aad2fd7	link	true	/test unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.