-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendor: update kvproto #6461
vendor: update kvproto #6461
Conversation
So I just update kvproto now, manually call
It seems somebody don't make the right update last time, so some extra files is included after this operation. |
/run-all-tests |
But the kvproto in vendor does not changed. |
Locked *LockInfo `protobuf:"bytes,1,opt,name=locked" json:"locked,omitempty"` | ||
Retryable string `protobuf:"bytes,2,opt,name=retryable,proto3" json:"retryable,omitempty"` | ||
Abort string `protobuf:"bytes,3,opt,name=abort,proto3" json:"abort,omitempty"` | ||
Conflict *WriteConflict `protobuf:"bytes,4,opt,name=conflict" json:"conflict,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's changed @shenli
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
go-grpc-middleware need to be locked, because it specify a different version of grpc.
I'd like to update kvproto for #6457, and
make update
get me here.PTAL @zhexuany @coocood