ingest: fix default region split size and keys in nextgen#64540
Conversation
|
Hi @D3Hunter. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-nextgen-20251011 |
|
@D3Hunter: once the present PR merges, I will cherry-pick it on top of release-nextgen-20251011 in the new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #64540 +/- ##
================================================
+ Coverage 72.6887% 75.0338% +2.3450%
================================================
Files 1866 1889 +23
Lines 506414 516318 +9904
================================================
+ Hits 368106 387413 +19307
+ Misses 115929 105172 -10757
- Partials 22379 23733 +1354
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
/retest |
|
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fzzf678, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
@D3Hunter: new pull request created to branch DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #64526, ref #61702
Problem Summary:
What changed and how does it work?
nextgen has different setting for region split.
since nextgen we only support global sort, and each ingest subtask is about 100G, so max 100 regions on default setting, will not exceed the limit mentioned in the issue
Check List
Tests
apply below diff, so we always fail to get the region split setting from PD
in nextgen
in classic
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.