ingest: skip write when the region has no leader (#64442)#64470
Merged
ti-chi-bot[bot] merged 1 commit intoNov 14, 2025
Conversation
13 tasks
D3Hunter
approved these changes
Nov 13, 2025
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release-nextgen-20251011 #64470 +/- ##
=============================================================
Coverage ? 72.5618%
=============================================================
Files ? 1856
Lines ? 503955
Branches ? 0
=============================================================
Hits ? 365679
Misses ? 116189
Partials ? 22087
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, D3Hunter The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
e62af4b
into
pingcap:release-nextgen-20251011
17 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #64442
What problem does this PR solve?
Issue Number: close #64422, ref #61702
Problem Summary:
What changed and how does it work?
this issue only happens in nextgen, as classic region job worker already have an additional leader check after write to tikv, we fix this by check region leader before write, so for classic kernel we can avoid the useless write
tidb/pkg/lightning/backend/local/region_job.go
Line 632 in 87152f7
also log the unretryable error, to help debug and direct us to add more retryable error
Check List
Tests
we run the same scenario in the issue, no such error again, and we can see errors like below when there is no leader for some scanned region
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.