Skip to content

importinto: fix TestGlobalSortMultiFiles fail on classic kernel#64462

Merged
ti-chi-bot[bot] merged 3 commits into
pingcap:masterfrom
D3Hunter:fix-flaky-test-in-classic
Nov 13, 2025
Merged

importinto: fix TestGlobalSortMultiFiles fail on classic kernel#64462
ti-chi-bot[bot] merged 3 commits into
pingcap:masterfrom
D3Hunter:fix-flaky-test-in-classic

Conversation

@D3Hunter

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: ref #61702

Problem Summary:

What changed and how does it work?

TestGlobalSortMultiFiles is changed in #64402, it works on nextgen, but it always fails on classic kernel, but i am not sure why the CI merges it

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 13, 2025
@tiprow

tiprow Bot commented Nov 13, 2025

Copy link
Copy Markdown

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot Bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 13, 2025
@@ -222,7 +222,7 @@ func (s *mockGCSSuite) TestGlobalSortMultiFiles() {
// 1 subtask, encoding 10 files using 4 threads.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// 1 subtask, encoding 10 files using 4 threads.
// 1 subtask, encoding 10 files.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i will separate them into 2 cases

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ti-chi-bot

ti-chi-bot Bot commented Nov 13, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, joechenrh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 13, 2025
@ti-chi-bot

ti-chi-bot Bot commented Nov 13, 2025

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2025-11-13 07:49:54.186455068 +0000 UTC m=+947643.629484947: ☑️ agreed by GMHDBJD.
  • 2025-11-13 07:50:56.514239034 +0000 UTC m=+947705.957268923: ☑️ agreed by joechenrh.

@codecov

codecov Bot commented Nov 13, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.3862%. Comparing base (3acae2d) to head (841752d).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #64462        +/-   ##
================================================
+ Coverage   72.6901%   73.3862%   +0.6961%     
================================================
  Files          1866       1867         +1     
  Lines        506190     506637       +447     
================================================
+ Hits         367950     371802      +3852     
+ Misses       115861     112611      -3250     
+ Partials      22379      22224       -155     
Flag Coverage Δ
integration 41.8316% <ø> (?)
unit 72.5218% <ø> (+0.2527%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <ø> (ø)
parser ∅ <ø> (∅)
br 46.2413% <ø> (+0.0976%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@D3Hunter

Copy link
Copy Markdown
Contributor Author

/hold

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2025
@ti-chi-bot ti-chi-bot Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 13, 2025
@D3Hunter

Copy link
Copy Markdown
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2025
@ti-chi-bot ti-chi-bot Bot merged commit d4c1408 into pingcap:master Nov 13, 2025
27 checks passed
@D3Hunter D3Hunter deleted the fix-flaky-test-in-classic branch November 13, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants