importinto: fix TestGlobalSortMultiFiles fail on classic kernel#64462
Conversation
|
Hi @D3Hunter. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| @@ -222,7 +222,7 @@ func (s *mockGCSSuite) TestGlobalSortMultiFiles() { | |||
| // 1 subtask, encoding 10 files using 4 threads. | |||
There was a problem hiding this comment.
| // 1 subtask, encoding 10 files using 4 threads. | |
| // 1 subtask, encoding 10 files. |
There was a problem hiding this comment.
i will separate them into 2 cases
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: GMHDBJD, joechenrh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #64462 +/- ##
================================================
+ Coverage 72.6901% 73.3862% +0.6961%
================================================
Files 1866 1867 +1
Lines 506190 506637 +447
================================================
+ Hits 367950 371802 +3852
+ Misses 115861 112611 -3250
+ Partials 22379 22224 -155
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
/hold |
|
/unhold |
What problem does this PR solve?
Issue Number: ref #61702
Problem Summary:
What changed and how does it work?
TestGlobalSortMultiFilesis changed in #64402, it works on nextgen, but it always fails on classic kernel, but i am not sure why the CI merges itCheck List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.