store/tikv/gc_worker: Create new backoffer for each region #6438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zhangjinpeng1987 PTAL |
|
/run-all-tests |
|
CI failed, please fix it @MyonKeminta . |
|
Seems it's not what I can fix.. please re-run the test.. |
|
/run-sqllogic-test |
|
@coocood @tiancaiamao PTAL |
|
Please resolve the conflicts @MyonKeminta . |
tiancaiamao
reviewed
May 24, 2018
store/tikv/backoff.go
Outdated
| cleanupMaxBackoff = 20000 | ||
| GcOneRegionMaxBackoff = 20000 | ||
| GcResolveLockMaxBackoff = 100000 | ||
| DeleteRangeOneRegionMaxBackoff = 100000 |
There was a problem hiding this comment.
It's not used outside this package? Then you should use lower case variable.
|
LGTM |
tiancaiamao
approved these changes
May 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A GC job consists of 3 steps: resolving locks, deleting ranges, and doing GC. Previously, the first two steps use only one backoffer each, with the limit equals to 10,0000, regardless how large the task is. As a result, the larger the DB or the delete range tasks is, the more likely the GC job runs into a failure, which may cause more troubling problems.
To reduce the possibility that GC jobs fail, I create a new backoffer for each region when resolving lock and deleting ranges.