dxf: fix incorrect worker count metric when total task count exceed schedule limit#64321
Conversation
|
Hi @D3Hunter. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: GMHDBJD, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #64321 +/- ##
================================================
+ Coverage 72.7432% 73.4995% +0.7563%
================================================
Files 1861 1862 +1
Lines 504392 505588 +1196
================================================
+ Hits 366911 371605 +4694
+ Misses 115176 111886 -3290
+ Partials 22305 22097 -208
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
/cherry-pick release-nextgen-20251011 |
|
@D3Hunter: once the present PR merges, I will cherry-pick it on top of release-nextgen-20251011 in the new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
@D3Hunter: new pull request created to branch DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: ref #61702
Problem Summary:
What changed and how does it work?
we pass the wrong tasks param when calculate for the worker count metric
Check List
Tests
apply this diff, we we can only run at most 2 task at the same time, force the task concurrency = node CPU, and let the task wait
previously
after
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.