Skip to content

metric: show import-into merge speed in nextgen#63998

Merged
ti-chi-bot[bot] merged 2 commits into
pingcap:masterfrom
D3Hunter:import-merge-speed
Oct 17, 2025
Merged

metric: show import-into merge speed in nextgen#63998
ti-chi-bot[bot] merged 2 commits into
pingcap:masterfrom
D3Hunter:import-merge-speed

Conversation

@D3Hunter

@D3Hunter D3Hunter commented Oct 16, 2025

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: ref #61702

Problem Summary:

What changed and how does it work?

merge speed is gathered after #62550, but we forget to add it for nextgen when add panels for tidb-worker in #63510

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 16, 2025
@tiprow

tiprow Bot commented Oct 16, 2025

Copy link
Copy Markdown

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 16, 2025
@codecov

codecov Bot commented Oct 16, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.1630%. Comparing base (d7169b2) to head (5f53b95).
⚠️ Report is 10 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #63998        +/-   ##
================================================
+ Coverage   72.7193%   73.1630%   +0.4437%     
================================================
  Files          1850       1851         +1     
  Lines        500310     502662      +2352     
================================================
+ Hits         363822     367763      +3941     
+ Misses       114337     112821      -1516     
+ Partials      22151      22078        -73     
Flag Coverage Δ
integration 41.9298% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <ø> (ø)
parser ∅ <ø> (∅)
br 46.3772% <ø> (+0.0076%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codecov

codecov Bot commented Oct 16, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.4025%. Comparing base (d7169b2) to head (5f53b95).
⚠️ Report is 273 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #63998        +/-   ##
================================================
+ Coverage   72.7193%   73.4025%   +0.6832%     
================================================
  Files          1850       1852         +2     
  Lines        500310     501818      +1508     
================================================
+ Hits         363822     368347      +4525     
+ Misses       114337     111437      -2900     
+ Partials      22151      22034       -117     
Flag Coverage Δ
integration 41.9298% <ø> (?)
unit 72.5152% <ø> (+0.2583%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <ø> (ø)
parser ∅ <ø> (∅)
br 46.4406% <ø> (+0.0709%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@D3Hunter

Copy link
Copy Markdown
Contributor Author

/retest

@tiprow

tiprow Bot commented Oct 16, 2025

Copy link
Copy Markdown

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 16, 2025
@ti-chi-bot

ti-chi-bot Bot commented Oct 16, 2025

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2025-10-16 11:14:50.705471059 +0000 UTC m=+351996.782723609: ☑️ agreed by joechenrh.
  • 2025-10-16 14:58:26.451268073 +0000 UTC m=+365412.528520632: ☑️ agreed by tangenta.

@ti-chi-bot

ti-chi-bot Bot commented Oct 17, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joechenrh, tangenta, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Oct 17, 2025
@ti-chi-bot ti-chi-bot Bot merged commit 2374d3a into pingcap:master Oct 17, 2025
29 checks passed
@D3Hunter D3Hunter deleted the import-merge-speed branch October 17, 2025 02:31
@ti-chi-bot ti-chi-bot Bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Dec 16, 2025
@ti-chi-bot

Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #65076.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 16, 2025
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants