add-index: use max-node-count as hint when split subtasks on nextgen#63861
Conversation
|
Hi @D3Hunter. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| // in nextgen, node resource are scaled out automatically, we only consider | ||
| // the max allowed node for the task, and ignore how many node currently | ||
| // available. | ||
| nodeCnt = task.MaxNodeCount |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #63861 +/- ##
================================================
+ Coverage 72.7354% 74.9228% +2.1874%
================================================
Files 1849 1896 +47
Lines 499590 507801 +8211
================================================
+ Hits 363379 380459 +17080
+ Misses 114126 103879 -10247
- Partials 22085 23463 +1378
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tangenta, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/retest |
|
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |

What problem does this PR solve?
Issue Number: ref #61702
Problem Summary:
What changed and how does it work?
as title, as in nextgen, node resource are scaled out automatically
Check List
Tests
before this PR, we only have 1 node currently, and only split 1 subtask, even if the max-node-count is 12
after this PR, we mock max-node to be 10, 2 subtasks are splitted, as we only have 2 regions on local environment
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.