Skip to content

tests: fix upgrade bdr unit tests for next-gen#63770

Merged
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
tangenta:next-gen-fix-bdr-ut
Sep 26, 2025
Merged

tests: fix upgrade bdr unit tests for next-gen#63770
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
tangenta:next-gen-fix-bdr-ut

Conversation

@tangenta

@tangenta tangenta commented Sep 26, 2025

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: ref #61702

Problem Summary:

Next-gen's first TiDB bootstrap version is 250, we should start from 250 to avoid upgradeToVer248's error.

What changed and how does it work?

  • Fix TestUpgradeVersion245Primary and TestUpgradeVersion245Secondary.
  • Skip TestMultiSchemaTruncatePartitionWithGlobalIndex temporarily to enable the next-gen UT CI first. So that no more test failures will be introduced.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: tangenta <tangenta@126.com>
@ti-chi-bot ti-chi-bot Bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Sep 26, 2025
@tiprow

tiprow Bot commented Sep 26, 2025

Copy link
Copy Markdown

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot Bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 26, 2025
@ti-chi-bot

ti-chi-bot Bot commented Sep 26, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 26, 2025
@ti-chi-bot

ti-chi-bot Bot commented Sep 26, 2025

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2025-09-26 07:35:48.421815662 +0000 UTC m=+601358.492309344: ☑️ agreed by wjhuang2016.
  • 2025-09-26 07:41:58.684409648 +0000 UTC m=+601728.754903345: ☑️ agreed by D3Hunter.

@wuhuizuo

Copy link
Copy Markdown
Contributor

/test pull-unit-test-next-gen

@tiprow

tiprow Bot commented Sep 26, 2025

Copy link
Copy Markdown

@wuhuizuo: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test pull-unit-test-next-gen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov

codecov Bot commented Sep 26, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.9500%. Comparing base (44b374f) to head (54f72f1).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #63770        +/-   ##
================================================
+ Coverage   72.7741%   74.9500%   +2.1758%     
================================================
  Files          1845       1892        +47     
  Lines        498882     507082      +8200     
================================================
+ Hits         363057     380058     +17001     
+ Misses       113821     103611     -10210     
- Partials      22004      23413      +1409     
Flag Coverage Δ
integration 48.3995% <ø> (?)
unit 72.5421% <ø> (+0.2279%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <ø> (ø)
parser ∅ <ø> (∅)
br 63.3168% <ø> (+16.9135%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wuhuizuo

Copy link
Copy Markdown
Contributor

/retest

@tiprow

tiprow Bot commented Sep 26, 2025

Copy link
Copy Markdown

@wuhuizuo: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot Bot merged commit 74ea11d into pingcap:master Sep 26, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants