Skip to content

test: fix analyze tests for next-gen#63668

Merged
ti-chi-bot[bot] merged 3 commits into
pingcap:masterfrom
tangenta:nextgen-fix-analyze-test
Sep 22, 2025
Merged

test: fix analyze tests for next-gen#63668
ti-chi-bot[bot] merged 3 commits into
pingcap:masterfrom
tangenta:nextgen-fix-analyze-test

Conversation

@tangenta

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: ref #61702

Problem Summary:

Unistore's analyze index processor cannot handle encoded index keys.

What changed and how does it work?

  • Strip the prefixed keyspace before decoding index key.
  • Fix TestAnalyzeColumnsWithVirtualColumnIndex, TestAnalyzeMVIndex and TestNormalAnalyzeOnCommonHandle.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

…TestNormalAnalyzeOnCommonHandle

Signed-off-by: tangenta <tangenta@126.com>
@ti-chi-bot ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 22, 2025
@tiprow

tiprow Bot commented Sep 22, 2025

Copy link
Copy Markdown

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot Bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 22, 2025
@tangenta tangenta changed the title test: fix three analyze tests for next-gen test: fix analyze tests for next-gen Sep 22, 2025
@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 22, 2025
@ti-chi-bot

ti-chi-bot Bot commented Sep 22, 2025

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2025-09-22 13:16:07.421089189 +0000 UTC m=+276177.491582863: ☑️ agreed by winoros.
  • 2025-09-22 13:30:20.354521513 +0000 UTC m=+277030.425015191: ☑️ agreed by hawkingrei.

@hawkingrei

Copy link
Copy Markdown
Contributor

/retest

@codecov

codecov Bot commented Sep 22, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 16.66667% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.1815%. Comparing base (724cd2f) to head (b179eeb).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #63668        +/-   ##
================================================
+ Coverage   72.7910%   73.1815%   +0.3905%     
================================================
  Files          1842       1842                
  Lines        497997     498130       +133     
================================================
+ Hits         362497     364539      +2042     
+ Misses       113528     111634      -1894     
+ Partials      21972      21957        -15     
Flag Coverage Δ
integration 42.0064% <16.6666%> (?)
unit 72.2971% <16.6666%> (-0.0289%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <ø> (ø)
parser ∅ <ø> (∅)
br 46.3816% <ø> (-0.0279%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: tangenta <tangenta@126.com>
@ti-chi-bot ti-chi-bot Bot added the sig/planner SIG: Planner label Sep 22, 2025
@ti-chi-bot

ti-chi-bot Bot commented Sep 22, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: tangenta <tangenta@126.com>
@ti-chi-bot ti-chi-bot Bot merged commit 140d1d1 into pingcap:master Sep 22, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants