next-gen: fix tablesample test and null keyspace test by tangenta · Pull Request #63599 · pingcap/tidb

tangenta · 2025-09-18T07:17:59Z

What problem does this PR solve?

Issue Number: ref #61702

Problem Summary:

What changed and how does it work?

Skip null keyspace test in next-gen.
Set tablesample end key to table end key if the length is zero.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: tangenta <tangenta@126.com>

tiprow · 2025-09-18T07:18:18Z

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

D3Hunter · 2025-09-18T07:42:31Z

-		store, err = mockstore.NewMockStore(mockstore.WithStoreType(mockstore.EmbedUnistore))
+		store, err = mockstore.NewMockStore(
+			mockstore.WithStoreType(mockstore.EmbedUnistore),
+			mockstore.WithKeyspaceMeta(nil))


why set it to nil, what about nextgen?

The purpose of this test to is test null keyspace. This option is to revert the next-gen's setting, keeping keyspace meta nil.

maybe skip it for nextgen? nextgen don't have null keyspace

I think it is fine to keep this test? It only affect tests

maybe skip it completely, let it run only in classic kernel

then i guess we can revert the change in pkg/store/mockstore/mockstore.go too

codecov · 2025-09-18T08:57:39Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.1275%. Comparing base (8debad9) to head (c62c499).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #63599        +/-   ##
================================================
+ Coverage   72.7876%   73.1275%   +0.3398%     
================================================
  Files          1840       1842         +2     
  Lines        497513     499697      +2184     
================================================
+ Hits         362128     365416      +3288     
+ Misses       113374     112285      -1089     
+ Partials      22011      21996        -15

Flag	Coverage Δ
integration	`42.0075% <100.0000%> (?)`
unit	`72.3470% <100.0000%> (+0.0193%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.7568% <ø> (-0.1133%)`	⬇️
parser	`∅ <ø> (∅)`
br	`46.3485% <ø> (-0.1536%)`	⬇️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: tangenta <tangenta@126.com>

tangenta · 2025-09-18T17:02:12Z

/retest

tiprow · 2025-09-18T17:02:34Z

@tangenta: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tangenta · 2025-09-19T01:20:50Z

/retest

tiprow · 2025-09-19T01:21:14Z

@tangenta: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: tangenta <tangenta@126.com>

Co-authored-by: D3Hunter <jujj603@gmail.com>

ti-chi-bot · 2025-09-19T05:32:13Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, fzzf678

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [D3Hunter]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2025-09-19T05:32:16Z

[LGTM Timeline notifier]

Timeline:

2025-09-19 03:33:43.732331437 +0000 UTC m=+157185.210912084: ☑️ agreed by D3Hunter.
2025-09-19 05:32:15.50248573 +0000 UTC m=+164296.981066378: ☑️ agreed by fzzf678.

hawkingrei · 2025-09-19T05:52:27Z

/retest

next-gen: fix tablesample test and null keyspace test

cd3cc7b

Signed-off-by: tangenta <tangenta@126.com>

ti-chi-bot Bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 18, 2025

ti-chi-bot Bot removed the do-not-merge/needs-tests-checked label Sep 18, 2025

D3Hunter reviewed Sep 18, 2025

View reviewed changes

check region end key by length

d74dddd

Signed-off-by: tangenta <tangenta@126.com>

address comment

a30a385

Signed-off-by: tangenta <tangenta@126.com>

ti-chi-bot Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 19, 2025

D3Hunter approved these changes Sep 19, 2025

View reviewed changes

Comment thread pkg/session/bootstrap_test.go Outdated

ti-chi-bot Bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 19, 2025

Update pkg/session/bootstrap_test.go

c62c499

Co-authored-by: D3Hunter <jujj603@gmail.com>

fzzf678 approved these changes Sep 19, 2025

View reviewed changes

ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 19, 2025

ti-chi-bot Bot merged commit 78f79d0 into pingcap:master Sep 19, 2025
28 checks passed

D3Hunter mentioned this pull request Sep 22, 2025

DXF service on nextgen kernel #61702

Open

Uh oh!

Conversation

tangenta commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

Uh oh!

tiprow Bot commented Sep 18, 2025

Uh oh!

D3Hunter Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

tangenta Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

D3Hunter Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

tangenta Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

D3Hunter Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov Bot commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

tangenta commented Sep 18, 2025

Uh oh!

tiprow Bot commented Sep 18, 2025

Uh oh!

tangenta commented Sep 19, 2025

Uh oh!

tiprow Bot commented Sep 19, 2025

Uh oh!

Uh oh!

ti-chi-bot Bot commented Sep 19, 2025

Uh oh!

ti-chi-bot Bot commented Sep 19, 2025

[LGTM Timeline notifier]

Uh oh!

hawkingrei commented Sep 19, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tangenta commented Sep 18, 2025 •

edited

Loading

tangenta Sep 18, 2025 •

edited

Loading

codecov Bot commented Sep 18, 2025 •

edited

Loading