upgrade: fix upgrade failed on nextgen#63569
Conversation
|
Hi @D3Hunter. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tangenta, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #63569 +/- ##
================================================
+ Coverage 72.8126% 74.7551% +1.9425%
================================================
Files 1840 1886 +46
Lines 497488 505696 +8208
================================================
+ Hits 362234 378034 +15800
+ Misses 113271 104220 -9051
- Partials 21983 23442 +1459
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
What problem does this PR solve?
Issue Number: ref #61702
Problem Summary:
after #63524, nextgen will have the need to upgrade, and at that time we have merged the pr to cal resource params for reorg related ddl. for modify column, we actually don't need to cal the param, but we will get the table size as the first step, so will fail
What changed and how does it work?
during init for reorg params, we auto calculate resource related params for nextgen, but during upgrade, DXF service hasn't initialized, and we shouldn't use DXF service to run boot related DDL
Check List
Tests
bootstrap nextgen cluster before hash 365cc25, then upgrade to master, it will fail with
if we upgrade to this PR, it will success
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.