importinto: fix zero update time during validation phase and refine logs#63425
Conversation
|
Hi @D3Hunter. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-nextgen-20250815 |
|
@D3Hunter: once the present PR merges, I will cherry-pick it on top of release-nextgen-20250815 in the new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/retest |
|
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #63425 +/- ##
================================================
+ Coverage 72.7588% 73.1966% +0.4377%
================================================
Files 1835 1835
Lines 496690 496774 +84
================================================
+ Hits 361386 363622 +2236
+ Misses 113324 111249 -2075
+ Partials 21980 21903 -77
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: GMHDBJD, joechenrh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@D3Hunter: new pull request created to branch DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: ref #61702
Problem Summary:
What changed and how does it work?
we add update time in #62283, the value is from update time of subtask summary, but during validation phase, we don't have subtask level summary. this pr change to use the update time of the job itself in this case
refine logs to print related task/subtask id and other info
Check List
Tests
before, at validating step,
Last_Update_Timeis zeroafter this PR, we can see the
Last_Update_Timeis shown correctlyprocess chunk can print the task/subtask id
print table id during scheduler, and print task info during other split subtasks of encode step
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.