Skip to content

test: fix next-gen CI failure cases#63352

Merged
ti-chi-bot[bot] merged 2 commits into
pingcap:masterfrom
CbcWestwolf:fix_next_gen_ci
Sep 3, 2025
Merged

test: fix next-gen CI failure cases#63352
ti-chi-bot[bot] merged 2 commits into
pingcap:masterfrom
CbcWestwolf:fix_next_gen_ci

Conversation

@CbcWestwolf

@CbcWestwolf CbcWestwolf commented Sep 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

What problem does this PR solve?

Issue Number: ref #61702

Problem Summary:

What changed and how does it work?

Fix:

  • TestSetDDLReorgMaxWriteSpeed
  • TestAddIndexUniqueFailOnDuplicate
  • TestMultiRegionGetTableEndHandle
  • TestMultiRegionGetTableEndCommonHandle

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 3, 2025
@CbcWestwolf

CbcWestwolf commented Sep 3, 2025

Copy link
Copy Markdown
Member Author

/test pull-unit-test-next-gen

@tiprow

tiprow Bot commented Sep 3, 2025

Copy link
Copy Markdown

@CbcWestwolf: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

Details

In response to this:

/test pull-unit-test-next-gen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov

codecov Bot commented Sep 3, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.7683%. Comparing base (99deeb3) to head (13aa677).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #63352        +/-   ##
================================================
+ Coverage   72.7728%   74.7683%   +1.9954%     
================================================
  Files          1832       1878        +46     
  Lines        495807     504132      +8325     
================================================
+ Hits         360813     376931     +16118     
+ Misses       113055     103848      -9207     
- Partials      21939      23353      +1414
Flag Coverage Δ
integration 48.4783% <0.0000%> (?)
unit 72.3134% <0.0000%> (+0.0643%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <ø> (ø)
parser ∅ <ø> (∅)
br 63.2026% <ø> (+16.6807%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@CbcWestwolf

CbcWestwolf commented Sep 3, 2025

Copy link
Copy Markdown
Member Author

/retest

@CbcWestwolf

CbcWestwolf commented Sep 3, 2025

Copy link
Copy Markdown
Member Author

/test pull-unit-test-next-gen

@tiprow

tiprow Bot commented Sep 3, 2025

Copy link
Copy Markdown

@CbcWestwolf: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

Details

In response to this:

/test pull-unit-test-next-gen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@CbcWestwolf

CbcWestwolf commented Sep 3, 2025

Copy link
Copy Markdown
Member Author

/retest

D3Hunter
D3Hunter reviewed Sep 3, 2025
View reviewed changes
Comment thread pkg/ddl/index_modify_test.go
if kerneltype.IsClassic() {
tk.MustExec("set @@tidb_ddl_reorg_worker_cnt = 1;")
}
if kerneltype.IsNextGen() {

@D3Hunter D3Hunter Sep 3, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the data size, if <25g, the auto calculated concurrency is 1 already

@CbcWestwolf CbcWestwolf Sep 3, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now mock table size instead
13aa677 (#63352)

@ti-chi-bot ti-chi-bot Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 3, 2025
@ti-chi-bot ti-chi-bot Bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 3, 2025
@ti-chi-bot

ti-chi-bot Bot commented Sep 3, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, fzzf678

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 3, 2025
@ti-chi-bot

ti-chi-bot Bot commented Sep 3, 2025

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2025-09-03 10:11:46.749180362 +0000 UTC m=+1850.732277810: ☑️ agreed by D3Hunter.
  • 2025-09-03 10:25:45.254579168 +0000 UTC m=+2689.237676606: ☑️ agreed by fzzf678.

@D3Hunter

D3Hunter commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

/retest

@ti-chi-bot

ti-chi-bot Bot commented Sep 3, 2025 •
edited
Loading

Copy link
Copy Markdown

@CbcWestwolf: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
non-block/pull-unit-test-next-gen 485951d link false /test pull-unit-test-next-gen

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@CbcWestwolf

CbcWestwolf commented Sep 3, 2025

Copy link
Copy Markdown
Member Author

/retest

@ti-chi-bot ti-chi-bot Bot merged commit 06463e2 into pingcap:master Sep 3, 2025
31 checks passed
@CbcWestwolf CbcWestwolf deleted the fix_next_gen_ci branch September 3, 2025 14:33
@D3Hunter D3Hunter mentioned this pull request Sep 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@D3Hunter D3Hunter D3Hunter approved these changes
@tangenta tangenta Awaiting requested review from tangenta
+1 more reviewer
@fzzf678 fzzf678 fzzf678 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CbcWestwolf @D3Hunter @fzzf678