Skip to content

sem: add tidb_cloud_storage_uri to SEM hidden variable list#63333

Merged
ti-chi-bot[bot] merged 2 commits into
pingcap:masterfrom
tangenta:next-gen-hide-cloud-storage-uri
Sep 2, 2025
Merged

sem: add tidb_cloud_storage_uri to SEM hidden variable list#63333
ti-chi-bot[bot] merged 2 commits into
pingcap:masterfrom
tangenta:next-gen-hide-cloud-storage-uri

Conversation

@tangenta

@tangenta tangenta commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: ref #61702

Problem Summary:

In next-gen TiDB, DXF subtasks are executed in SYSTEM keyspace TiDB. The variable tidb_cloud_storage_uri should be set by the cloud control panel, instead of users.

What changed and how does it work?

  • Add tidb_cloud_storage_uri to SEM hidden variable list.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
mysql> set @@global.tidb_cloud_storage_uri = '';
ERROR 1227 (42000): Access denied; you need (at least one of) the RESTRICTED_VARIABLES_ADMIN privilege(s) for this operation
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: tangenta <tangenta@126.com>
@ti-chi-bot ti-chi-bot Bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 2, 2025
@tiprow

tiprow Bot commented Sep 2, 2025

Copy link
Copy Markdown

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@YangKeao YangKeao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 2, 2025
@codecov

codecov Bot commented Sep 2, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.8065%. Comparing base (0f8643f) to head (a959fd8).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #63333        +/-   ##
================================================
+ Coverage   72.7832%   74.8065%   +2.0233%     
================================================
  Files          1832       1878        +46     
  Lines        495794     504274      +8480     
================================================
+ Hits         360855     377230     +16375     
+ Misses       113010     103716      -9294     
- Partials      21929      23328      +1399     
Flag Coverage Δ
integration 48.5726% <100.0000%> (?)
unit 72.3309% <100.0000%> (+0.0789%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <ø> (ø)
parser ∅ <ø> (∅)
br 63.4309% <ø> (+16.8988%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread pkg/ddl/reorg_util.go Outdated
zap.Bool("enableFastReorg", m.IsFastReorg),
zap.String("targetScope", m.TargetScope),
zap.Int("maxNodeCount", m.MaxNodeCount),
zap.Int64("tableSizeInBytes", tableSizeInBytes),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use units.ByteSize for better visibility

@ti-chi-bot

ti-chi-bot Bot commented Sep 2, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 2, 2025
@ti-chi-bot

ti-chi-bot Bot commented Sep 2, 2025

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2025-09-02 09:17:00.669410349 +0000 UTC m=+863712.547241293: ☑️ agreed by YangKeao.
  • 2025-09-02 09:58:00.193402581 +0000 UTC m=+866172.071233535: ☑️ agreed by D3Hunter.

@D3Hunter

D3Hunter commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

/hold

you can unhold youself

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 2, 2025
Signed-off-by: tangenta <tangenta@126.com>
@tangenta tangenta removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 2, 2025
@D3Hunter

D3Hunter commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

/unhold

@D3Hunter

D3Hunter commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

/cherry-pick release-nextgen-20250815

@ti-chi-bot

Copy link
Copy Markdown
Member

@D3Hunter: once the present PR merges, I will cherry-pick it on top of release-nextgen-20250815 in the new PR and assign it to you.

Details

In response to this:

/cherry-pick release-nextgen-20250815

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@D3Hunter

D3Hunter commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

/retest

@tiprow

tiprow Bot commented Sep 2, 2025

Copy link
Copy Markdown

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot Bot merged commit c2b9dd0 into pingcap:master Sep 2, 2025
29 checks passed
@ti-chi-bot

Copy link
Copy Markdown
Member

@D3Hunter: new pull request created to branch release-nextgen-20250815: #63344.

Details

In response to this:

/cherry-pick release-nextgen-20250815

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 2, 2025
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants