sem: add tidb_cloud_storage_uri to SEM hidden variable list#63333
Conversation
Signed-off-by: tangenta <tangenta@126.com>
|
Hi @tangenta. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #63333 +/- ##
================================================
+ Coverage 72.7832% 74.8065% +2.0233%
================================================
Files 1832 1878 +46
Lines 495794 504274 +8480
================================================
+ Hits 360855 377230 +16375
+ Misses 113010 103716 -9294
- Partials 21929 23328 +1399
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
| zap.Bool("enableFastReorg", m.IsFastReorg), | ||
| zap.String("targetScope", m.TargetScope), | ||
| zap.Int("maxNodeCount", m.MaxNodeCount), | ||
| zap.Int64("tableSizeInBytes", tableSizeInBytes), |
There was a problem hiding this comment.
use units.ByteSize for better visibility
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold you can unhold youself |
Signed-off-by: tangenta <tangenta@126.com>
|
/unhold |
|
/cherry-pick release-nextgen-20250815 |
|
@D3Hunter: once the present PR merges, I will cherry-pick it on top of release-nextgen-20250815 in the new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/retest |
|
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@D3Hunter: new pull request created to branch DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: ref #61702
Problem Summary:
In next-gen TiDB, DXF subtasks are executed in SYSTEM keyspace TiDB. The variable
tidb_cloud_storage_urishould be set by the cloud control panel, instead of users.What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.