test: skip some upgrade tests for next-gen by CbcWestwolf · Pull Request #63331 · pingcap/tidb

CbcWestwolf · 2025-09-02T08:35:06Z

What problem does this PR solve?

Issue Number: ref #61702

Problem Summary:

Since in next-gen cluster all tables that are created by bootstrap can not have non-clustered primary key, we can skip the test cases containing upgradeToVer248

What changed and how does it work?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

CbcWestwolf · 2025-09-02T08:36:50Z

/test pull-unit-test-next-gen

tiprow · 2025-09-02T08:36:56Z

@CbcWestwolf: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test tidb_parser_test

Use /test all to run all jobs.

Details

In response to this:

/test pull-unit-test-next-gen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

codecov · 2025-09-02T09:01:12Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.2624%. Comparing base (3d9a0eb) to head (6dafc78).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #63331        +/-   ##
================================================
+ Coverage   72.7832%   73.2624%   +0.4791%     
================================================
  Files          1832       1832                
  Lines        495794     496159       +365     
================================================
+ Hits         360855     363498      +2643     
+ Misses       113010     110814      -2196     
+ Partials      21929      21847        -82

Flag	Coverage Δ
integration	`42.0544% <ø> (?)`
unit	`72.3309% <ø> (+0.0788%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.8700% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`46.5345% <ø> (+0.0025%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

CbcWestwolf · 2025-09-02T09:08:52Z

/test pull-unit-test-next-gen

tiprow · 2025-09-02T09:08:58Z

@CbcWestwolf: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test tidb_parser_test

Use /test all to run all jobs.

Details

In response to this:

/test pull-unit-test-next-gen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

CbcWestwolf · 2025-09-02T09:09:48Z

/test pull-unit-test-next-gen

tiprow · 2025-09-02T09:09:55Z

@CbcWestwolf: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test tidb_parser_test

Use /test all to run all jobs.

Details

In response to this:

/test pull-unit-test-next-gen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

CbcWestwolf · 2025-09-02T09:10:33Z

/test pull-unit-test-next-gen

tiprow · 2025-09-02T09:10:38Z

@CbcWestwolf: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test tidb_parser_test

Use /test all to run all jobs.

Details

In response to this:

/test pull-unit-test-next-gen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

CbcWestwolf · 2025-09-02T09:12:58Z

/retest

CbcWestwolf · 2025-09-02T09:42:30Z

/retest

ti-chi-bot · 2025-09-02T09:56:47Z

@CbcWestwolf: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
non-block/pull-unit-test-next-gen	`798955d`	link	false	`/test pull-unit-test-next-gen`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Co-authored-by: D3Hunter <jujj603@gmail.com>

D3Hunter · 2025-09-02T10:03:00Z

 }

 func TestIssue17979_1(t *testing.T) {
+	if kerneltype.IsNextGen() {


is this related to upgrade?

Yes, they call BootstrapSession

normal bootstrap also call BootstrapSession, i mean does it call the upgrade process?

Yes, the call stack is

D3Hunter · 2025-09-02T10:04:14Z

 }

 func TestIssue17979_2(t *testing.T) {
+	if kerneltype.IsNextGen() {


ti-chi-bot · 2025-09-02T14:00:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [D3Hunter,tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2025-09-02T14:00:38Z

[LGTM Timeline notifier]

Timeline:

2025-09-02 09:58:08.773036761 +0000 UTC m=+866180.650867715: ☑️ agreed by tangenta.
2025-09-02 14:00:36.774296217 +0000 UTC m=+880728.652127171: ☑️ agreed by D3Hunter.

test: skip some upgration tests for next-gen

798955d

ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 2, 2025

tangenta approved these changes Sep 2, 2025

View reviewed changes

ti-chi-bot Bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 2, 2025

D3Hunter changed the title ~~test: skip some upgration tests for next-gen~~ test: skip some upgrade tests for next-gen Sep 2, 2025

D3Hunter reviewed Sep 2, 2025

View reviewed changes

Comment thread pkg/server/handler/tests/http_handler_test.go Outdated

Update pkg/server/handler/tests/http_handler_test.go

1280e7c

Co-authored-by: D3Hunter <jujj603@gmail.com>

D3Hunter reviewed Sep 2, 2025

View reviewed changes

update

6dafc78

D3Hunter approved these changes Sep 2, 2025

View reviewed changes

ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 2, 2025

ti-chi-bot Bot merged commit bb8af19 into pingcap:master Sep 2, 2025
26 checks passed

CbcWestwolf deleted the skip_next_gen_bootstrap_test branch September 2, 2025 14:38

CbcWestwolf mentioned this pull request Sep 3, 2025

test: skip some upgrade tests for next-gen (part 2) #63350

Merged

13 tasks

D3Hunter mentioned this pull request Sep 4, 2025

DXF service on nextgen kernel #61702

Open

Uh oh!

Conversation

CbcWestwolf commented Sep 2, 2025

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

Uh oh!

CbcWestwolf commented Sep 2, 2025

Uh oh!

tiprow Bot commented Sep 2, 2025

Uh oh!

codecov Bot commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

CbcWestwolf commented Sep 2, 2025

Uh oh!

tiprow Bot commented Sep 2, 2025

Uh oh!

CbcWestwolf commented Sep 2, 2025

Uh oh!

tiprow Bot commented Sep 2, 2025

Uh oh!

CbcWestwolf commented Sep 2, 2025

Uh oh!

tiprow Bot commented Sep 2, 2025

Uh oh!

CbcWestwolf commented Sep 2, 2025

Uh oh!

CbcWestwolf commented Sep 2, 2025

Uh oh!

ti-chi-bot Bot commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

D3Hunter Sep 2, 2025

Choose a reason for hiding this comment

Uh oh!

CbcWestwolf Sep 2, 2025

Choose a reason for hiding this comment

Uh oh!

D3Hunter Sep 2, 2025

Choose a reason for hiding this comment

Uh oh!

CbcWestwolf Sep 2, 2025

Choose a reason for hiding this comment

Uh oh!

D3Hunter Sep 2, 2025

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot Bot commented Sep 2, 2025

Uh oh!

ti-chi-bot Bot commented Sep 2, 2025

[LGTM Timeline notifier]

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Sep 2, 2025 •

edited

Loading

ti-chi-bot Bot commented Sep 2, 2025 •

edited

Loading