Skip to content

test: fix panic in TestManager and TestDoDDLJobQuit in nextgen#63324

Merged
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
D3Hunter:fix-some-nextgen-case
Sep 2, 2025
Merged

test: fix panic in TestManager and TestDoDDLJobQuit in nextgen#63324
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
D3Hunter:fix-some-nextgen-case

Conversation

@D3Hunter

@D3Hunter D3Hunter commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: ref #61702

Problem Summary:

What changed and how does it work?

crossks_test.TestManager and "test_test.TestDoDDLJobQuit" panic previously, we fix them in this pr

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 2, 2025
@tiprow

tiprow Bot commented Sep 2, 2025

Copy link
Copy Markdown

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov

codecov Bot commented Sep 2, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.7409%. Comparing base (72427c5) to head (e32d297).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #63324        +/-   ##
================================================
+ Coverage   72.7890%   74.7409%   +1.9519%     
================================================
  Files          1832       1878        +46     
  Lines        495785     504156      +8371     
================================================
+ Hits         360877     376811     +15934     
+ Misses       112972     103949      -9023     
- Partials      21936      23396      +1460     
Flag Coverage Δ
integration 48.4662% <0.0000%> (?)
unit 72.2520% <33.3333%> (-0.0061%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <ø> (ø)
parser ∅ <ø> (∅)
br 63.2863% <ø> (+16.8000%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Benjamin2037 Benjamin2037 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 2, 2025
@D3Hunter

D3Hunter commented Sep 2, 2025

Copy link
Copy Markdown
Contributor Author

/retest

@tiprow

tiprow Bot commented Sep 2, 2025

Copy link
Copy Markdown

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 2, 2025
@ti-chi-bot

ti-chi-bot Bot commented Sep 2, 2025

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2025-09-02 05:59:41.215743176 +0000 UTC m=+851873.093574131: ☑️ agreed by Benjamin2037.
  • 2025-09-02 06:20:31.444772745 +0000 UTC m=+853123.322603700: ☑️ agreed by CbcWestwolf.

@D3Hunter

D3Hunter commented Sep 2, 2025

Copy link
Copy Markdown
Contributor Author

/approve

@ti-chi-bot

ti-chi-bot Bot commented Sep 2, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, CbcWestwolf, D3Hunter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Sep 2, 2025
@ti-chi-bot ti-chi-bot Bot merged commit 0f8643f into pingcap:master Sep 2, 2025
28 checks passed
@D3Hunter D3Hunter deleted the fix-some-nextgen-case branch September 2, 2025 07:37
@ekexium ekexium mentioned this pull request Sep 2, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants