Code Review Analysis for PR #63192: test: fix rest unit test for next-gen

[Copilot]

This PR provides a comprehensive code review analysis for PR #63192, which fixes unit tests to support the next-gen kernel implementation in TiDB. The review identifies critical issues and provides actionable feedback following TiDB's code review guidelines.

Review Summary

PR #63192 is part of the larger DXF service on nextgen kernel feature (#61702) and makes extensive changes to test infrastructure to support both classic and next-gen kernel modes. While the changes are necessary and well-intentioned, several critical issues need to be addressed before merge.

Key Findings

Critical Issues Identified

1. Test Resource Management: The signature change of NewMockStoreWithoutBootstrap removes the cleanup mechanism that was previously handled by t.Cleanup(), potentially causing memory leaks in tests.

2. Global Config Isolation: Direct modification of global configuration without proper cleanup could lead to test isolation failures and flaky tests.

3. Schema Tracker Constructor Overload: Database creation logic added to the NewChecker constructor introduces side effects that could make the code harder to test and maintain.

Positive Aspects

• Consistent use of kerneltype.IsNextGen() for conditional logic
• Proper test skipping for MDL-related functionality in next-gen
• Clean abstraction for key encoding differences between API versions
• Comprehensive coverage across all necessary test files

Recommendations

The review provides specific, actionable feedback formatted as questions following TiDB's review guidelines of being kind to the coder and asking questions rather than making statements. The main recommendations include:

1. Implementing proper resource cleanup mechanisms
2. Using test-scoped configuration management
3. Refactoring schema tracker initialization
4. Updating documentation for breaking changes

Impact

This review analysis helps ensure that the next-gen kernel test infrastructure changes maintain code quality standards while properly supporting the new functionality. The feedback aims to prevent potential issues with test reliability and maintainability.

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[ti-chi-bot]

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

Hi @Copilot. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[pingcap-cla-assistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[tiprow]

Hi @Copilot. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ti-chi-bot]

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.

_{📖 For more info, you can check the "Contribute Code" section in the development guide.}

---

Notice: To remove the do-not-merge/needs-tests-checked label, please finished the tests then check the finished items in description.

For example:

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

_{📖 For more info, you can check the "Contribute Code" section in the development guide.}