dxf: start scheduler without reserve resource in nextgen#63205
Conversation
|
Hi @D3Hunter. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #63205 +/- ##
================================================
+ Coverage 72.7903% 74.7617% +1.9714%
================================================
Files 1831 1877 +46
Lines 495232 504183 +8951
================================================
+ Hits 360481 376936 +16455
+ Misses 112839 103866 -8973
- Partials 21912 23381 +1469
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
| } | ||
| require.Eventually(t, func() bool { | ||
| taskKeys := getRunningTaskKeys() | ||
| return err == nil && len(taskKeys) == 0 |
There was a problem hiding this comment.
| return err == nil && len(taskKeys) == 0 | |
| return len(taskKeys) == 0 |
ditto for other place
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joechenrh, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/retest |
|
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
/cherry-pick release-nextgen-20250815 |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
@D3Hunter: new pull request created to branch DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: ref #61702
Problem Summary:
What changed and how does it work?
in nextgen kernel, node resource will be scaled automatically by cluster controller which will use the schedule status API to make sure the required resource is available
also fix the integration tests in disttask pkg when run in nextgen
Check List
Tests
apply below diff
code diff
run below script
before this PR, in the 2 queries of
mysql.tidb_global_task;, we can see the second task is not scheduledand the result of schedule status, we can see required_count is 1
after this PR, in the 2 queries of
mysql.tidb_global_task;, we can see both tasks are scheduledand the result of schedule status, we can see required_count is 2
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.