dxf/crossks: check by inner fields not global var and make crossks real tikvtest work by D3Hunter · Pull Request #62918 · pingcap/tidb

D3Hunter · 2025-08-11T07:40:06Z

What problem does this PR solve?

Issue Number: ref #61702

Problem Summary:

What changed and how does it work?

make DDL global owner manager consider keyspace, so we can create multiple domain of different keyspace in real-tikv test
print TiDB version in tests/integrationtest/run-tests.sh, so we can check whether nextgen build is used in the CI output.
check which keyspace we are running in by kv.Storage, not by the global config, so we can start multiple domain in real-tikv test
pass store to DXF component explicitly, not through function clousure, to make sure start multiple store/domain works
remove some dependency on the global TaskManager by storing it in the related scheduler/task-executor
add closed to Storage to avoid close twice
add realtikvtest.WithKeepSystemStore to realtikv testkit, to let SYSTEM store managed

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

change change

tiprow · 2025-08-11T07:40:28Z

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

codecov · 2025-08-11T08:02:35Z

Codecov Report

❌ Patch coverage is 67.01031% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.0484%. Comparing base (c879288) to head (56c23d7).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #62918        +/-   ##
================================================
+ Coverage   72.7919%   75.0484%   +2.2565%     
================================================
  Files          1798       1851        +53     
  Lines        487998     503584     +15586     
================================================
+ Hits         355223     377932     +22709     
+ Misses       111164     102419      -8745     
- Partials      21611      23233      +1622

Flag	Coverage Δ
integration	`49.4639% <23.2558%> (?)`
unit	`72.4167% <65.9793%> (+0.2407%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.8700% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`63.1977% <100.0000%> (+16.8689%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…-tikvtest-work

D3Hunter · 2025-08-11T09:43:56Z

/retest

tiprow · 2025-08-11T09:44:18Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

D3Hunter · 2025-08-11T16:22:23Z

/retest

tiprow · 2025-08-11T16:22:47Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

D3Hunter · 2025-08-12T01:03:54Z

/retest

tiprow · 2025-08-12T01:04:17Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

…-tikvtest-work

D3Hunter · 2025-08-13T11:31:59Z

/hold

need some adjust after #62860 merged, we need to make sure domain closed before store

D3Hunter · 2025-08-13T11:42:14Z

/unhold

D3Hunter · 2025-08-14T02:10:26Z

/retest

tiprow · 2025-08-14T02:10:48Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

D3Hunter · 2025-08-14T02:46:09Z

/retest

tiprow · 2025-08-14T02:46:36Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

D3Hunter · 2025-08-14T02:53:46Z

/retest

tiprow · 2025-08-14T02:54:09Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

D3Hunter · 2025-08-14T03:31:36Z

/retest

tiprow · 2025-08-14T03:31:59Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

D3Hunter · 2025-08-14T03:45:11Z

/retest

tiprow · 2025-08-14T03:45:34Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot · 2025-08-14T08:05:38Z

[LGTM Timeline notifier]

Timeline:

2025-08-13 06:21:40.774385209 +0000 UTC m=+421299.808968437: ☑️ agreed by tangenta.
2025-08-14 08:05:37.164688539 +0000 UTC m=+513936.199271777: ☑️ agreed by wjhuang2016.

ti-chi-bot · 2025-08-14T08:46:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leavrth, tangenta, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [Leavrth,tangenta,wjhuang2016]
~~br/OWNERS~~ [Leavrth]
~~pkg/ddl/OWNERS~~ [tangenta,wjhuang2016]
~~pkg/disttask/OWNERS~~ [tangenta,wjhuang2016]
~~pkg/domain/OWNERS~~ [tangenta,wjhuang2016]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

D3Hunter · 2025-08-14T08:56:26Z

/retest

tiprow · 2025-08-14T08:56:50Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

D3Hunter · 2025-08-14T10:01:04Z

/retest

tiprow · 2025-08-14T10:01:27Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

hawkingrei · 2025-08-14T13:59:40Z

/retest

D3Hunter · 2025-08-15T02:07:29Z

/cherry-pick release-nextgen-20250815

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2025-08-15T02:08:14Z

@D3Hunter: new pull request created to branch release-nextgen-20250815: #63006.
But this PR has conflicts, please resolve them!

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

…al tikvtest work (#62918) (#63006) ref #61702

…al tikvtest work (pingcap#62918) ref pingcap#61702

D3Hunter added 6 commits August 11, 2025 15:29

change

3a7d38f

change change

use local var

cb538b8

reduce dep on global var

ac86322

change

95c4b21

change

35358b1

remove comment

326057b

ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 11, 2025

D3Hunter added 4 commits August 11, 2025 16:04

bazel

43e6e93

fix test

1e48b35

Merge remote-tracking branch 'upstream/master' into make-crossks-real…

7601d55

…-tikvtest-work

fix test

f24ecbe

D3Hunter added 2 commits August 11, 2025 18:30

fix test

e1c99ec

fix test

e8e2e20

D3Hunter mentioned this pull request Aug 12, 2025

DXF service on nextgen kernel #61702

Open

tangenta approved these changes Aug 13, 2025

View reviewed changes

ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 13, 2025

Merge remote-tracking branch 'upstream/master' into make-crossks-real…

74aa8c7

…-tikvtest-work

ti-chi-bot Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 13, 2025

abstract test

56c23d7

wjhuang2016 approved these changes Aug 14, 2025

View reviewed changes

ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 14, 2025

Leavrth approved these changes Aug 14, 2025

View reviewed changes

ti-chi-bot Bot added the approved label Aug 14, 2025

ti-chi-bot Bot merged commit 9cd2b03 into pingcap:master Aug 14, 2025
45 of 52 checks passed

D3Hunter deleted the make-crossks-real-tikvtest-work branch August 15, 2025 01:03

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Aug 15, 2025

This is an automated cherry-pick of pingcap#62918

4db71b9

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Aug 15, 2025

dxf/crossks: check by inner fields not global var and make crossks real tikvtest work (#62918) #63006

Merged

13 tasks

ti-chi-bot Bot pushed a commit that referenced this pull request Aug 15, 2025

dxf/crossks: check by inner fields not global var and make crossks re…

9555e16

…al tikvtest work (#62918) (#63006) ref #61702

joechenrh pushed a commit to joechenrh/tidb that referenced this pull request Aug 18, 2025

dxf/crossks: check by inner fields not global var and make crossks re…

015aef3

…al tikvtest work (pingcap#62918) ref pingcap#61702

Uh oh!

Conversation

D3Hunter commented Aug 11, 2025

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

Uh oh!

tiprow Bot commented Aug 11, 2025

Uh oh!

codecov Bot commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

D3Hunter commented Aug 11, 2025

Uh oh!

tiprow Bot commented Aug 11, 2025

Uh oh!

D3Hunter commented Aug 11, 2025

Uh oh!

tiprow Bot commented Aug 11, 2025

Uh oh!

D3Hunter commented Aug 12, 2025

Uh oh!

tiprow Bot commented Aug 12, 2025

Uh oh!

D3Hunter commented Aug 13, 2025

Uh oh!

D3Hunter commented Aug 13, 2025

Uh oh!

D3Hunter commented Aug 14, 2025

Uh oh!

tiprow Bot commented Aug 14, 2025

Uh oh!

D3Hunter commented Aug 14, 2025

Uh oh!

tiprow Bot commented Aug 14, 2025

Uh oh!

D3Hunter commented Aug 14, 2025

Uh oh!

tiprow Bot commented Aug 14, 2025

Uh oh!

D3Hunter commented Aug 14, 2025

Uh oh!

tiprow Bot commented Aug 14, 2025

Uh oh!

D3Hunter commented Aug 14, 2025

Uh oh!

tiprow Bot commented Aug 14, 2025

Uh oh!

ti-chi-bot Bot commented Aug 14, 2025

[LGTM Timeline notifier]

Uh oh!

ti-chi-bot Bot commented Aug 14, 2025

Uh oh!

D3Hunter commented Aug 14, 2025

Uh oh!

tiprow Bot commented Aug 14, 2025

Uh oh!

D3Hunter commented Aug 14, 2025

Uh oh!

tiprow Bot commented Aug 14, 2025

Uh oh!

hawkingrei commented Aug 14, 2025

Uh oh!

Uh oh!

D3Hunter commented Aug 15, 2025

Uh oh!

ti-chi-bot commented Aug 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov Bot commented Aug 11, 2025 •

edited

Loading