tests: fix unit tests for next-gen by tangenta · Pull Request #62895 · pingcap/tidb

tangenta · 2025-08-08T06:52:40Z

What problem does this PR solve?

Issue Number: ref #61702

Problem Summary:

What changed and how does it work?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: tangenta <tangenta@126.com>

tiprow · 2025-08-08T06:52:57Z

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

codecov · 2025-08-08T07:10:51Z

Codecov Report

❌ Patch coverage is 58.06452% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.9136%. Comparing base (d08f914) to head (1e3729d).
⚠️ Report is 58 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #62895        +/-   ##
================================================
+ Coverage   72.8153%   74.9136%   +2.0982%     
================================================
  Files          1795       1869        +74     
  Lines        487761     516025     +28264     
================================================
+ Hits         355165     386573     +31408     
+ Misses       110983     105993      -4990     
- Partials      21613      23459      +1846

Flag	Coverage Δ
integration	`48.5903% <0.0000%> (?)`
unit	`72.4786% <58.0645%> (+0.2888%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.8700% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`62.9443% <ø> (+16.6150%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: tangenta <tangenta@126.com>

…-test

tangenta · 2025-08-11T07:36:11Z

/test pull-unit-test-next-gen

tiprow · 2025-08-11T07:36:33Z

@tangenta: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test pull-unit-test-next-gen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: tangenta <tangenta@126.com>

tangenta · 2025-08-11T08:20:35Z

/test pull-unit-test-next-gen

tiprow · 2025-08-11T08:21:02Z

@tangenta: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test pull-unit-test-next-gen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

D3Hunter

rest lgtm

Signed-off-by: tangenta <tangenta@126.com>

wuhuizuo · 2025-08-14T01:07:54Z

/test pull-unit-test-next-gen

tiprow · 2025-08-14T01:08:19Z

@wuhuizuo: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test pull-unit-test-next-gen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tangenta · 2025-08-14T04:11:57Z

/test pull-unit-test-next-gen

tiprow · 2025-08-14T04:12:19Z

@tangenta: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test pull-unit-test-next-gen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: tangenta <tangenta@126.com>

tiprow · 2025-08-19T08:44:17Z

@tangenta: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test pull-unit-test-next-gen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: tangenta <tangenta@126.com>

…sChunkWith Signed-off-by: tangenta <tangenta@126.com>

wuhuizuo · 2025-08-20T01:46:16Z

/test pull-unit-test-next-gen

tiprow · 2025-08-20T01:46:38Z

@wuhuizuo: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test pull-unit-test-next-gen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

hawkingrei · 2025-08-20T01:48:43Z

/ok-to-test

Signed-off-by: tangenta <tangenta@126.com>

D3Hunter · 2025-08-20T03:45:06Z


 func TestTiDBUpgradeWithDistTaskEnable(t *testing.T) {
+	if kerneltype.IsNextGen() {
+		t.Skip("next-gen kernel system tables have different clustered pk setting, dropping pk will fail in upgradeToVer248")


Suggested change

t.Skip("next-gen kernel system tables have different clustered pk setting, dropping pk will fail in upgradeToVer248")

t.Skip("the schema version of the first next-gen kernel release is 250, no need to go through upgrade operations below it, skip it")

please modify other messages too

Signed-off-by: tangenta <tangenta@126.com>

tangenta · 2025-08-20T06:30:10Z

/approve

tangenta · 2025-08-20T06:31:01Z

/retest

Benjamin2037

LGTM

ti-chi-bot · 2025-08-20T09:22:14Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, cfzjywxk, D3Hunter, hawkingrei, lance6716, tangenta, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [Benjamin2037,D3Hunter,XuHuaiyu,cfzjywxk,hawkingrei,lance6716,tangenta]
~~pkg/ddl/OWNERS~~ [Benjamin2037,D3Hunter,tangenta]
~~pkg/executor/importer/OWNERS~~ [Benjamin2037,D3Hunter]
~~pkg/expression/OWNERS~~ [XuHuaiyu]
~~pkg/infoschema/OWNERS~~ [Benjamin2037,D3Hunter,tangenta]
~~pkg/lightning/OWNERS~~ [Benjamin2037,D3Hunter]
~~pkg/planner/OWNERS~~ [hawkingrei]
~~pkg/table/OWNERS~~ [Benjamin2037,cfzjywxk,tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

hawkingrei · 2025-08-20T12:13:43Z

/retest

ti-chi-bot · 2025-08-20T13:59:13Z

@tangenta: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
non-block/pull-unit-test-next-gen	`94cb323`	link	false	`/test pull-unit-test-next-gen`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

hawkingrei · 2025-08-20T16:11:24Z

/retest

ref pingcap#61702

tests: fix unit tests for next-gen

a4d48a3

Signed-off-by: tangenta <tangenta@126.com>

ti-chi-bot Bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Aug 8, 2025

hawkingrei reviewed Aug 8, 2025

View reviewed changes

Comment thread pkg/store/mockstore/teststore/store.go

add license header

e65d744

Signed-off-by: tangenta <tangenta@126.com>

ti-chi-bot Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 8, 2025

Merge remote-tracking branch 'upstream/master' into next-gen-fix-unit…

1d2c122

…-test

fix TestResourceGroupTagEncoding

a71bcfd

Signed-off-by: tangenta <tangenta@126.com>

D3Hunter reviewed Aug 12, 2025

View reviewed changes

Comment thread pkg/kv/kv_test.go

Comment thread pkg/testkit/mockstore.go Outdated

D3Hunter mentioned this pull request Aug 12, 2025

DXF service on nextgen kernel #61702

Open

tangenta added 2 commits August 12, 2025 14:02

fix TestSyncerSimple and address comment

c9a0285

update bazel

4f18c0f

Signed-off-by: tangenta <tangenta@126.com>

D3Hunter approved these changes Aug 12, 2025

View reviewed changes

ti-chi-bot Bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 12, 2025

wuhuizuo added the nextgen Indicates that the Issue or PR belongs to the nextgen kernel architecture. label Aug 14, 2025

remove nil check in SetSystemStorage

08efb62

Signed-off-by: tangenta <tangenta@126.com>

tangenta added 3 commits August 19, 2025 20:10

fix TestInitMeta, TestGlobalVariablesOnFlashback and TestShowIndex

5b098c2

Signed-off-by: tangenta <tangenta@126.com>

refine

6e39336

Signed-off-by: tangenta <tangenta@126.com>

fix TestInfoSchemaDDLJobs, TestTiDBUpgradeWithDistTask and TestProces…

94cb323

…sChunkWith Signed-off-by: tangenta <tangenta@126.com>

hawkingrei approved these changes Aug 20, 2025

View reviewed changes

ti-chi-bot Bot added the ok-to-test Indicates a PR is ready to be tested. label Aug 20, 2025

D3Hunter reviewed Aug 20, 2025

View reviewed changes

Comment thread pkg/session/session.go Outdated

Comment thread DEPS.bzl

Comment thread DEPS.bzl

revert next-gen system table clustered pk config

475d0fa

Signed-off-by: tangenta <tangenta@126.com>

D3Hunter reviewed Aug 20, 2025

View reviewed changes

Comment thread pkg/executor/importer/importer_testkit_test.go Outdated

D3Hunter reviewed Aug 20, 2025

View reviewed changes

Comment thread pkg/executor/importer/importer_testkit_test.go Outdated

tangenta added 2 commits August 20, 2025 12:00

address comments

7037b91

Signed-off-by: tangenta <tangenta@126.com>

remove comment

1e3729d

Signed-off-by: tangenta <tangenta@126.com>

XuHuaiyu approved these changes Aug 20, 2025

View reviewed changes

Benjamin2037 approved these changes Aug 20, 2025

View reviewed changes

cfzjywxk approved these changes Aug 20, 2025

View reviewed changes

ti-chi-bot Bot added the approved label Aug 20, 2025

ti-chi-bot Bot merged commit 8c88b61 into pingcap:master Aug 20, 2025
28 checks passed

tangenta added a commit to tangenta/tidb that referenced this pull request Aug 21, 2025

tests: fix unit tests for next-gen (pingcap#62895)

7cedad7

ref pingcap#61702

tangenta added a commit to tangenta/tidb that referenced this pull request Aug 21, 2025

tests: fix unit tests for next-gen (pingcap#62895)

19d469b

ref pingcap#61702

tangenta mentioned this pull request Aug 21, 2025

tests: fix unit tests for next-gen (#62895) #63119

Closed

13 tasks

	t.Skip("next-gen kernel system tables have different clustered pk setting, dropping pk will fail in upgradeToVer248")
	t.Skip("the schema version of the first next-gen kernel release is 250, no need to go through upgrade operations below it, skip it")

Uh oh!

Conversation

tangenta commented Aug 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

Uh oh!

tiprow Bot commented Aug 8, 2025

Uh oh!

Uh oh!

codecov Bot commented Aug 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

tangenta commented Aug 11, 2025

Uh oh!

tiprow Bot commented Aug 11, 2025

Uh oh!

tangenta commented Aug 11, 2025

Uh oh!

tiprow Bot commented Aug 11, 2025

Uh oh!

D3Hunter left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

wuhuizuo commented Aug 14, 2025

Uh oh!

tiprow Bot commented Aug 14, 2025

Uh oh!

tangenta commented Aug 14, 2025

Uh oh!

tiprow Bot commented Aug 14, 2025

Uh oh!

tiprow Bot commented Aug 19, 2025

Uh oh!

wuhuizuo commented Aug 20, 2025

Uh oh!

tiprow Bot commented Aug 20, 2025

Uh oh!

hawkingrei commented Aug 20, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

D3Hunter Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tangenta commented Aug 20, 2025

Uh oh!

tangenta commented Aug 20, 2025

Uh oh!

Benjamin2037 left a comment

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot Bot commented Aug 20, 2025

Uh oh!

hawkingrei commented Aug 20, 2025

Uh oh!

ti-chi-bot Bot commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hawkingrei commented Aug 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

tangenta commented Aug 8, 2025 •

edited

Loading

codecov Bot commented Aug 8, 2025 •

edited

Loading

ti-chi-bot Bot commented Aug 20, 2025 •

edited

Loading