Skip to content

next-gen: forbid setting tidb_max_dist_task_nodes in user keyspace#62687

Closed
tangenta wants to merge 3 commits into
pingcap:masterfrom
tangenta:next-gen-forbid-max-nodes
Closed

next-gen: forbid setting tidb_max_dist_task_nodes in user keyspace#62687
tangenta wants to merge 3 commits into
pingcap:masterfrom
tangenta:next-gen-forbid-max-nodes

Conversation

@tangenta

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: ref #61702

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot Bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/planner SIG: Planner labels Jul 29, 2025
@tiprow

tiprow Bot commented Jul 29, 2025

Copy link
Copy Markdown

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: tangenta <tangenta@126.com>
@codecov

codecov Bot commented Jul 29, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 22.72727% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.8318%. Comparing base (b2bba33) to head (dba36a7).
⚠️ Report is 183 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #62687        +/-   ##
================================================
+ Coverage   72.8752%   74.8318%   +1.9566%     
================================================
  Files          1769       1818        +49     
  Lines        486105     499130     +13025     
================================================
+ Hits         354250     373508     +19258     
+ Misses       110214     102379      -7835     
- Partials      21641      23243      +1602     
Flag Coverage Δ
integration 48.7293% <20.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <ø> (ø)
parser ∅ <ø> (∅)
br 62.7614% <ø> (+16.4525%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: tangenta <tangenta@126.com>
@ti-chi-bot

ti-chi-bot Bot commented Jul 30, 2025

Copy link
Copy Markdown

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-tests-checked label, please finished the tests then check the finished items in description.

For example:

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

📖 For more info, you can check the "Contribute Code" section in the development guide.

@ti-chi-bot

ti-chi-bot Bot commented Jul 30, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign benjamin2037, benmeadowcroft, hawkingrei for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot

ti-chi-bot Bot commented Aug 21, 2025

Copy link
Copy Markdown

@tangenta: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
non-block/pull-unit-test-next-gen dba36a7 link false /test pull-unit-test-next-gen
non-block/pull-integration-e2e-test-next-gen dba36a7 link false /test pull-integration-e2e-test-next-gen
non-block/pull-mysql-test-next-gen dba36a7 link false /test pull-mysql-test-next-gen
idc-jenkins-ci-tidb/unit-test dba36a7 link true /test unit-test
pull-integration-realcluster-test-next-gen dba36a7 link true /test pull-integration-realcluster-test-next-gen

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@D3Hunter

Copy link
Copy Markdown
Contributor

replaced by #62995

@D3Hunter D3Hunter closed this Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants