Skip to content

*: enable unit test for nextgen#62684

Merged
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
D3Hunter:nextgen-ut
Jul 29, 2025
Merged

*: enable unit test for nextgen#62684
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
D3Hunter:nextgen-ut

Conversation

@D3Hunter

@D3Hunter D3Hunter commented Jul 29, 2025

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: ref #61702

Problem Summary:

What changed and how does it work?

as title, we add nextgen tag when running ut for next gen kernel. also update the keyspace config for CreateMockStoreAndDomainWithSchemaLease

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

nextgen tag is added when NEXT_GEN=1

~/code/pingcap/tidb git:[master] make -n bazel_coverage_test bazel_coverage_test_ddlargsv1
GOBIN=/Users/jujiajia/code/pingcap/tidb/tools/bin GO111MODULE=on go install github.com/pingcap/failpoint/failpoint-ctl@9b3b6e3
find $PWD/ -mindepth 1 -type d | grep -vE "(\.git|\.idea|tools)" | xargs tools/bin/failpoint-ctl enable
bazel  run  //:gazelle
bazel  run   \
        --run_under="cd /Users/jujiajia/code/pingcap/tidb && " \
         //tools/tazel:tazel
bazel  --nohome_rc coverage  --instrument_test_targets --instrumentation_filter=//pkg/...,//br/...,//dumpling/... --jobs=35 --build_tests_only --test_keep_going=false \
        --@io_bazel_rules_go//go/config:cover_format=go_cover --define gotags=deadlock,intest \
        -- //... -//cmd/... -//tests/graceshutdown/... \
        -//tests/globalkilltest/... -//tests/readonlytest/... -//tests/realtikvtest/...
bazel  --nohome_rc coverage  --instrument_test_targets --instrumentation_filter=//pkg/...,//br/...,//dumpling/... --jobs=35 --build_tests_only --test_keep_going=false \
        --@io_bazel_rules_go//go/config:cover_format=go_cover --define gotags=deadlock,intest,ddlargsv1 \
        -- //... -//cmd/... -//tests/graceshutdown/... \
        -//tests/globalkilltest/... -//tests/readonlytest/... -//tests/realtikvtest/...


~/code/pingcap/tidb git:[master] NEXT_GEN=1 make -n bazel_coverage_test bazel_coverage_test_ddlargsv1
GOBIN=/Users/jujiajia/code/pingcap/tidb/tools/bin GO111MODULE=on go install github.com/pingcap/failpoint/failpoint-ctl@9b3b6e3
find $PWD/ -mindepth 1 -type d | grep -vE "(\.git|\.idea|tools)" | xargs tools/bin/failpoint-ctl enable
bazel  run  //:gazelle
bazel  run   \
        --run_under="cd /Users/jujiajia/code/pingcap/tidb && " \
         //tools/tazel:tazel
bazel  --nohome_rc coverage  --instrument_test_targets --instrumentation_filter=//pkg/...,//br/...,//dumpling/... --jobs=35 --build_tests_only --test_keep_going=false \
        --@io_bazel_rules_go//go/config:cover_format=go_cover --define gotags=deadlock,intest,nextgen \
        -- //... -//cmd/... -//tests/graceshutdown/... \
        -//tests/globalkilltest/... -//tests/readonlytest/... -//tests/realtikvtest/...
bazel  --nohome_rc coverage  --instrument_test_targets --instrumentation_filter=//pkg/...,//br/...,//dumpling/... --jobs=35 --build_tests_only --test_keep_going=false \
        --@io_bazel_rules_go//go/config:cover_format=go_cover --define gotags=deadlock,intest,nextgen,ddlargsv1 \
        -- //... -//cmd/... -//tests/graceshutdown/... \
        -//tests/globalkilltest/... -//tests/readonlytest/... -//tests/realtikvtest/...
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 29, 2025
@tiprow

tiprow Bot commented Jul 29, 2025

Copy link
Copy Markdown

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot

ti-chi-bot Bot commented Jul 29, 2025

Copy link
Copy Markdown

@wuhuizuo: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot Bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 29, 2025

@Benjamin2037 Benjamin2037 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot

ti-chi-bot Bot commented Jul 29, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, hawkingrei, wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [Benjamin2037,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 29, 2025
@ti-chi-bot

ti-chi-bot Bot commented Jul 29, 2025

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2025-07-29 08:29:20.727656504 +0000 UTC m=+66926.380408142: ☑️ agreed by hawkingrei.
  • 2025-07-29 08:32:18.475386737 +0000 UTC m=+67104.128138365: ☑️ agreed by Benjamin2037.

@codecov

codecov Bot commented Jul 29, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.3304%. Comparing base (0906244) to head (c9656ed).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #62684        +/-   ##
================================================
+ Coverage   72.8756%   73.3304%   +0.4548%     
================================================
  Files          1769       1769                
  Lines        486098     486353       +255     
================================================
+ Hits         354247     356645      +2398     
+ Misses       110206     108115      -2091     
+ Partials      21645      21593        -52     
Flag Coverage Δ
integration 42.3009% <ø> (?)
unit 72.2345% <ø> (+0.0804%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <ø> (ø)
parser ∅ <ø> (∅)
br 46.8206% <ø> (+0.4931%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@D3Hunter

Copy link
Copy Markdown
Contributor Author

/retest

@tiprow

tiprow Bot commented Jul 29, 2025

Copy link
Copy Markdown

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot

ti-chi-bot Bot commented Jul 29, 2025

Copy link
Copy Markdown

@D3Hunter: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
non-block/pull-integration-e2e-test-next-gen c9656ed link false /test pull-integration-e2e-test-next-gen
non-block/pull-unit-test-next-gen c9656ed link false /test pull-unit-test-next-gen
non-block/pull-mysql-test-next-gen c9656ed link false /test pull-mysql-test-next-gen

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot Bot merged commit 5a05600 into pingcap:master Jul 29, 2025
27 of 30 checks passed
@D3Hunter D3Hunter deleted the nextgen-ut branch July 29, 2025 13:10
JaySon-Huang pushed a commit to JaySon-Huang/tidb that referenced this pull request Aug 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants