Skip to content

infosync: move server info sync part of structs out to a separate pkg#62609

Merged
ti-chi-bot[bot] merged 4 commits into
pingcap:masterfrom
D3Hunter:move-def-infosync
Jul 25, 2025
Merged

infosync: move server info sync part of structs out to a separate pkg#62609
ti-chi-bot[bot] merged 4 commits into
pingcap:masterfrom
D3Hunter:move-def-infosync

Conversation

@D3Hunter

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: ref #61702

Problem Summary:

What changed and how does it work?

for cross keyspace of nextgen, we need to sync the info schema too for system tables, so we need to register the instance which is accessing cross keyspace session as a separate virtual server, so we will abstract the server info sync part out of info sync to make it standalone

in this PR, we only move some struct and constant, as the change is quite large, so file a separate PR.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test ONLY MOVE AND RENAME STRUCTS, NO LOGIC CHANGE
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. sig/planner SIG: Planner labels Jul 24, 2025
@tiprow

tiprow Bot commented Jul 24, 2025

Copy link
Copy Markdown

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Comment on lines +96 to +97
StaticInfo
DynamicInfo

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename those structs won't affect json marshal, https://pkg.go.dev/encoding/json

Embedded struct fields are usually marshaled as if their inner exported fields were fields in the outer struct,

@codecov

codecov Bot commented Jul 24, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 81.10236% with 24 lines in your changes missing coverage. Please review.

Project coverage is 74.8534%. Comparing base (b40975c) to head (d44b6d6).
Report is 14 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #62609        +/-   ##
================================================
+ Coverage   72.8645%   74.8534%   +1.9888%     
================================================
  Files          1767       1814        +47     
  Lines        485973     494723      +8750     
================================================
+ Hits         354102     370317     +16215     
+ Misses       110217     101280      -8937     
- Partials      21654      23126      +1472     
Flag Coverage Δ
integration 48.8058% <12.5984%> (?)
unit 72.1996% <81.1023%> (+0.0507%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7804% <ø> (ø)
parser ∅ <ø> (∅)
br 63.1541% <ø> (+16.8519%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@D3Hunter

Copy link
Copy Markdown
Contributor Author

/retest

@tiprow

tiprow Bot commented Jul 24, 2025

Copy link
Copy Markdown

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 25, 2025
@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 25, 2025
@ti-chi-bot

ti-chi-bot Bot commented Jul 25, 2025

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2025-07-25 03:27:56.921065098 +0000 UTC m=+133193.655081678: ☑️ agreed by joechenrh.
  • 2025-07-25 05:48:27.756712314 +0000 UTC m=+141624.490728904: ☑️ agreed by GMHDBJD.

@ti-chi-bot

ti-chi-bot Bot commented Jul 25, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, hawkingrei, joechenrh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Jul 25, 2025
@ti-chi-bot ti-chi-bot Bot merged commit 1ea1db4 into pingcap:master Jul 25, 2025
31 checks passed
@D3Hunter D3Hunter deleted the move-def-infosync branch July 25, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants