infosync: move server info sync part of structs out to a separate pkg#62609
Conversation
|
Hi @D3Hunter. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| StaticInfo | ||
| DynamicInfo |
There was a problem hiding this comment.
rename those structs won't affect json marshal, https://pkg.go.dev/encoding/json
Embedded struct fields are usually marshaled as if their inner exported fields were fields in the outer struct,
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #62609 +/- ##
================================================
+ Coverage 72.8645% 74.8534% +1.9888%
================================================
Files 1767 1814 +47
Lines 485973 494723 +8750
================================================
+ Hits 354102 370317 +16215
+ Misses 110217 101280 -8937
- Partials 21654 23126 +1472
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
/retest |
|
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: GMHDBJD, hawkingrei, joechenrh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #61702
Problem Summary:
What changed and how does it work?
for cross keyspace of nextgen, we need to sync the info schema too for system tables, so we need to register the instance which is accessing cross keyspace session as a separate virtual server, so we will abstract the server info sync part out of info sync to make it standalone
in this PR, we only move some struct and constant, as the change is quite large, so file a separate PR.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.