Skip to content

tests: add create index realtikv test for next_gen#62326

Merged
ti-chi-bot[bot] merged 9 commits into
pingcap:masterfrom
tangenta:tests-realtikv-add-index
Jul 18, 2025
Merged

tests: add create index realtikv test for next_gen#62326
ti-chi-bot[bot] merged 9 commits into
pingcap:masterfrom
tangenta:tests-realtikv-add-index

Conversation

@tangenta

@tangenta tangenta commented Jul 9, 2025

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: ref #61702

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: tangenta <tangenta@126.com>
@ti-chi-bot ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 9, 2025
@tiprow

tiprow Bot commented Jul 9, 2025

Copy link
Copy Markdown

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tangenta added 3 commits July 9, 2025 19:34
Signed-off-by: tangenta <tangenta@126.com>
Signed-off-by: tangenta <tangenta@126.com>
Signed-off-by: tangenta <tangenta@126.com>
@ti-chi-bot ti-chi-bot Bot added the sig/planner SIG: Planner label Jul 9, 2025
@codecov

codecov Bot commented Jul 9, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.0458%. Comparing base (5ec4f36) to head (89364eb).
Report is 54 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #62326        +/-   ##
================================================
+ Coverage   72.8857%   74.0458%   +1.1600%     
================================================
  Files          1751       1790        +39     
  Lines        484653     507071     +22418     
================================================
+ Hits         353243     375465     +22222     
+ Misses       109782     108927       -855     
- Partials      21628      22679      +1051     
Flag Coverage Δ
integration 45.3532% <0.0000%> (?)
unit 72.2637% <100.0000%> (+0.1235%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7804% <ø> (ø)
parser ∅ <ø> (∅)
br 46.3513% <ø> (+0.0318%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

tangenta added 3 commits July 9, 2025 23:16
Signed-off-by: tangenta <tangenta@126.com>
Signed-off-by: tangenta <tangenta@126.com>
Signed-off-by: tangenta <tangenta@126.com>
@tangenta

Copy link
Copy Markdown
Contributor Author

/retest

@tiprow

tiprow Bot commented Jul 10, 2025

Copy link
Copy Markdown

@tangenta: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Comment thread tests/realtikvtest/addindextest1/cross_ks_test.go Outdated
Comment thread tests/realtikvtest/addindextest1/cross_ks_test.go
Comment thread tests/realtikvtest/addindextest1/cross_ks_test.go Outdated
Comment thread tests/realtikvtest/testkit.go

@D3Hunter D3Hunter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

Comment thread tests/realtikvtest/addindextest1/cross_ks_test.go
Comment on lines +193 to +195
tk.MustExec("delete from mysql.tidb_global_task;")
tk.MustExec("delete from mysql.tidb_background_subtask;")
tk.MustExec("delete from mysql.tidb_ddl_job;")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why run those cleanup here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we can make sure there is no partial DDL/DXF state from the previous real tikv tests.

Signed-off-by: tangenta <tangenta@126.com>
Comment thread tests/realtikvtest/addindextest1/cross_ks_test.go
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 18, 2025
Co-authored-by: D3Hunter <jujj603@gmail.com>
@ti-chi-bot

ti-chi-bot Bot commented Jul 18, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 18, 2025
@ti-chi-bot

ti-chi-bot Bot commented Jul 18, 2025

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2025-07-18 04:43:06.441246065 +0000 UTC m=+2838839.164425051: ☑️ agreed by D3Hunter.
  • 2025-07-18 06:12:48.76623173 +0000 UTC m=+2844221.489410713: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot Bot merged commit 0fc2d8b into pingcap:master Jul 18, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants