meta/ddl: refactor ddl related sys table creation by D3Hunter · Pull Request #62301 · pingcap/tidb

D3Hunter · 2025-07-08T12:15:39Z

What problem does this PR solve?

Issue Number: ref #61702

Problem Summary:

What changed and how does it work?

rename some fields related to schema object ID, and move them to metadef pkg
simplify DDL table creation on bootstrap

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)

upgrade from 6.5.0/7.1.0/8.5.0 to this PR, all success

No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

tiprow · 2025-07-08T12:16:04Z

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

codecov · 2025-07-08T12:40:41Z

Codecov Report

Attention: Patch coverage is 64.28571% with 20 lines in your changes missing coverage. Please review.

Project coverage is 75.3491%. Comparing base (5c4977b) to head (ac6fdfc).
Report is 24 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #62301        +/-   ##
================================================
+ Coverage   72.8744%   75.3491%   +2.4747%     
================================================
  Files          1751       1801        +50     
  Lines        484572     502093     +17521     
================================================
+ Hits         353129     378323     +25194     
+ Misses       109822     100738      -9084     
- Partials      21621      23032      +1411

Flag	Coverage Δ
integration	`49.5746% <33.9285%> (?)`
unit	`72.6432% <64.2857%> (+0.5166%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.7804% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`63.1791% <ø> (+16.8646%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

D3Hunter · 2025-07-09T04:58:40Z

 }

-// InitMDLTable is to create tidb_mdl_info, which is used for metadata lock.
-func InitMDLTable(store kv.Storage) error {


the code is same as InitDDLJobTables, so unify them

D3Hunter · 2025-07-09T05:52:16Z

/retest

tiprow · 2025-07-09T05:52:38Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

D3Hunter · 2025-07-09T06:18:21Z

/retest

tiprow · 2025-07-09T06:18:45Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign in to view

-
 const (
 	// JobTable stores the information of DDL jobs.
 	JobTable = "tidb_ddl_job"


joechenrh

Rest LGTM

joechenrh · 2025-07-14T03:41:35Z

-
 const (
 	// JobTable stores the information of DDL jobs.
 	JobTable = "tidb_ddl_job"


JobTable is only used in these place:

getJobsBySQL, and all the place calling this function pass JobTable to tbl.

tidb/pkg/ddl/job_scheduler.go

Lines 811 to 816 in db81dee

func getJobsBySQL(

ctx context.Context,

se *sess.Session,

tbl, condition string,

) ([]*model.Job, error) {

rows, err := se.Execute(ctx, fmt.Sprintf("select job_meta from mysql.%s where %s", tbl, condition), "get_job")

getJobMetaFromTable and updateJobMeta2Table, both used in processAlterDDLJobConfig

checkAndSetFlashbackClusterInfo

Maybe we can remove JobTable in future too.

ti-chi-bot · 2025-07-14T03:42:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, joechenrh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [GMHDBJD]
~~pkg/ddl/OWNERS~~ [GMHDBJD]
~~pkg/meta/OWNERS~~ [GMHDBJD]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2025-07-14T03:42:24Z

[LGTM Timeline notifier]

Timeline:

2025-07-10 04:02:32.14706599 +0000 UTC m=+2145204.870244970: ☑️ agreed by GMHDBJD.
2025-07-14 03:42:23.678163937 +0000 UTC m=+2489596.401342921: ☑️ agreed by joechenrh.

D3Hunter · 2025-07-14T03:43:15Z

/hold

D3Hunter · 2025-07-14T03:57:59Z

/unhold

D3Hunter · 2025-07-14T06:36:23Z

/retest

tiprow · 2025-07-14T06:36:45Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

D3Hunter · 2025-07-14T06:53:03Z

/retest

tiprow · 2025-07-14T06:53:26Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

D3Hunter · 2025-07-14T07:31:20Z

/retest

tiprow · 2025-07-14T07:31:59Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

D3Hunter · 2025-07-14T09:03:02Z

/retest

tiprow · 2025-07-14T09:03:24Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

D3Hunter · 2025-07-14T09:39:55Z

/retest

tiprow · 2025-07-14T09:40:19Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

D3Hunter added 3 commits July 8, 2025 19:17

change

d1c2c20

change

8545bea

change

d495426

ti-chi-bot Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 8, 2025

rename

cb28a15

D3Hunter added 2 commits July 8, 2025 22:51

fix test

b0dd5e1

fix test

de3cadd

D3Hunter changed the title ~~[wip]meta/ddl: refactor ddl related sys table creation~~ meta/ddl: refactor ddl related sys table creation Jul 9, 2025

ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 9, 2025

D3Hunter commented Jul 9, 2025

View reviewed changes

D3Hunter added 2 commits July 9, 2025 12:59

add log

bf4f06e

add log

12f6db3

GMHDBJD approved these changes Jul 10, 2025

View reviewed changes

ti-chi-bot Bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 10, 2025

joechenrh reviewed Jul 11, 2025

View reviewed changes

Comment thread pkg/ddl/constant.go Outdated

const (

// JobTable stores the information of DDL jobs.

JobTable = "tidb_ddl_job"

This comment was marked as duplicate.

Sign in to view

joechenrh approved these changes Jul 14, 2025

View reviewed changes

ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 14, 2025

ti-chi-bot Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 14, 2025

fix comment

ac6fdfc

ti-chi-bot Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 14, 2025

ti-chi-bot Bot merged commit cdef1a3 into pingcap:master Jul 14, 2025
29 checks passed

D3Hunter deleted the refactor-sys-table-create branch July 14, 2025 17:41

D3Hunter mentioned this pull request Aug 12, 2025

DXF service on nextgen kernel #61702

Open

	func getJobsBySQL(
	ctx context.Context,
	se *sess.Session,
	tbl, condition string,
	) ([]*model.Job, error) {
	rows, err := se.Execute(ctx, fmt.Sprintf("select job_meta from mysql.%s where %s", tbl, condition), "get_job")

Uh oh!

Conversation

D3Hunter commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

Uh oh!

tiprow Bot commented Jul 8, 2025

Uh oh!

codecov Bot commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

D3Hunter Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

D3Hunter commented Jul 9, 2025

Uh oh!

tiprow Bot commented Jul 9, 2025

Uh oh!

D3Hunter commented Jul 9, 2025

Uh oh!

tiprow Bot commented Jul 9, 2025

Uh oh!

This comment was marked as duplicate.

Uh oh!

joechenrh left a comment

Choose a reason for hiding this comment

Uh oh!

joechenrh Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot Bot commented Jul 14, 2025

Uh oh!

ti-chi-bot Bot commented Jul 14, 2025

[LGTM Timeline notifier]

Uh oh!

D3Hunter commented Jul 14, 2025

Uh oh!

D3Hunter commented Jul 14, 2025

Uh oh!

D3Hunter commented Jul 14, 2025

Uh oh!

tiprow Bot commented Jul 14, 2025

Uh oh!

D3Hunter commented Jul 14, 2025

Uh oh!

tiprow Bot commented Jul 14, 2025

Uh oh!

D3Hunter commented Jul 14, 2025

Uh oh!

tiprow Bot commented Jul 14, 2025

Uh oh!

D3Hunter commented Jul 14, 2025

Uh oh!

tiprow Bot commented Jul 14, 2025

Uh oh!

D3Hunter commented Jul 14, 2025

Uh oh!

tiprow Bot commented Jul 14, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

D3Hunter commented Jul 8, 2025 •

edited

Loading

codecov Bot commented Jul 8, 2025 •

edited

Loading

D3Hunter Jul 9, 2025 •

edited

Loading

joechenrh Jul 14, 2025 •

edited

Loading