Skip to content

testkit: make ut works in nextgen after introduce SYSTEM ks#62113

Merged
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
D3Hunter:ut-nextgen
Jul 1, 2025
Merged

testkit: make ut works in nextgen after introduce SYSTEM ks#62113
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
D3Hunter:ut-nextgen

Conversation

@D3Hunter

@D3Hunter D3Hunter commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: ref #61702

Problem Summary:

What changed and how does it work?

	// in nextgen, SYSTEM ks must be bootstrapped first, to make UT easier, we
	// always run them inside SYSTEM keyspace, if your test requires bootstrapping
	// multiple keyspace, you should use CreateMockStoreAndDomainForKS instead.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

choose random test that uses CreateMockStoreAndDomain and CreateMockStoreWithSchemaLease, and run with nextgen tags, all success

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot Bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 1, 2025
@tiprow

tiprow Bot commented Jul 1, 2025

Copy link
Copy Markdown

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 1, 2025
@codecov

codecov Bot commented Jul 1, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.8752%. Comparing base (94bfb3d) to head (9af3f22).
Report is 5 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #62113        +/-   ##
================================================
+ Coverage   72.9233%   74.8752%   +1.9519%     
================================================
  Files          1739       1785        +46     
  Lines        482858     490997      +8139     
================================================
+ Hits         352116     367635     +15519     
+ Misses       109170     100289      -8881     
- Partials      21572      23073      +1501     
Flag Coverage Δ
integration 48.8066% <ø> (?)
unit 72.1693% <ø> (-0.0095%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7804% <ø> (ø)
parser ∅ <ø> (∅)
br 63.0038% <ø> (+16.6730%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 1, 2025
@ti-chi-bot

ti-chi-bot Bot commented Jul 1, 2025

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2025-07-01 07:05:47.381101238 +0000 UTC m=+1378600.104280220: ☑️ agreed by hawkingrei.
  • 2025-07-01 07:19:01.937657827 +0000 UTC m=+1379394.660836809: ☑️ agreed by lance6716.

@D3Hunter

D3Hunter commented Jul 1, 2025

Copy link
Copy Markdown
Contributor Author

/approve

@ti-chi-bot ti-chi-bot Bot added the approved label Jul 1, 2025
@ti-chi-bot

ti-chi-bot Bot commented Jul 1, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, hawkingrei, lance6716, tiancaiamao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot merged commit a90774c into pingcap:master Jul 1, 2025
26 checks passed
@D3Hunter D3Hunter deleted the ut-nextgen branch July 1, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants