Skip to content

fix: close issue 59457 by trim compare first#61915

Merged
ti-chi-bot[bot] merged 2 commits into
pingcap:masterfrom
yihong0618:hy/clouse_issue_59457
Jul 8, 2025
Merged

fix: close issue 59457 by trim compare first#61915
ti-chi-bot[bot] merged 2 commits into
pingcap:masterfrom
yihong0618:hy/clouse_issue_59457

Conversation

@yihong0618

@yihong0618 yihong0618 commented Jun 23, 2025

Copy link
Copy Markdown
Contributor

Thank you for contributing to TiDB!

This patch close issue #59457 by trim value to compare first

cc @YangKeao

Issue Number: close #59457

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@yihong0618
fix: close issue 59457 by trim compare first
24cfb1c 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@ti-chi-bot ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Jun 23, 2025
@ti-chi-bot

ti-chi-bot Bot commented Jun 23, 2025

Copy link
Copy Markdown

Hi @yihong0618. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tiprow

tiprow Bot commented Jun 23, 2025

Copy link
Copy Markdown

Hi @yihong0618. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

YangKeao
YangKeao approved these changes Jun 23, 2025
View reviewed changes

@YangKeao YangKeao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 23, 2025
@YangKeao YangKeao requested a review from XuHuaiyu June 23, 2025 08:56
@lance6716

lance6716 commented Jun 23, 2025

Copy link
Copy Markdown
Contributor

/ok-to-test

@ti-chi-bot ti-chi-bot Bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Jun 23, 2025
@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 23, 2025
@ti-chi-bot

ti-chi-bot Bot commented Jun 23, 2025

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2025-06-23 08:52:43.475861784 +0000 UTC m=+693816.199040767: ☑️ agreed by YangKeao.
  • 2025-06-23 11:07:16.520683678 +0000 UTC m=+701889.243862660: ☑️ agreed by lance6716.

@codecov

codecov Bot commented Jun 23, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Project coverage is 73.7221%. Comparing base (0fd4b17) to head (df46ca8).
Report is 10 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #61915        +/-   ##
================================================
+ Coverage   72.9018%   73.7221%   +0.8202%     
================================================
  Files          1750       1751         +1     
  Lines        484502     489012      +4510     
================================================
+ Hits         353211     360510      +7299     
+ Misses       109666     106832      -2834     
- Partials      21625      21670        +45
Flag Coverage Δ
integration 42.9661% <82.3529%> (?)
unit 72.6123% <64.7058%> (+0.4490%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7804% <ø> (ø)
parser ∅ <ø> (∅)
br 46.4327% <ø> (+0.1080%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lance6716

lance6716 commented Jul 7, 2025

Copy link
Copy Markdown
Contributor

/assign @windtalker

@lance6716

lance6716 commented Jul 7, 2025

Copy link
Copy Markdown
Contributor

Hi @yihong0618 please fix git conflict

@yihong0618

yihong0618 commented Jul 7, 2025

Copy link
Copy Markdown
Contributor Author

Hi @yihong0618 please fix git conflict

done

@yihong0618

yihong0618 commented Jul 7, 2025

Copy link
Copy Markdown
Contributor Author

one question...
how to check failed test from here....
image

it only show one failing...
@lance6716

@lance6716

lance6716 commented Jul 7, 2025

Copy link
Copy Markdown
Contributor

/retest

There's a "Show complete log" floating button. However I think it's caused by flaky tests.

@yihong0618

yihong0618 commented Jul 7, 2025

Copy link
Copy Markdown
Contributor Author

/retest

There's a "Show complete log" floating button. However I think it's caused by flaky tests.

Thank you!

windtalker
windtalker approved these changes Jul 8, 2025
View reviewed changes

@windtalker windtalker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot

ti-chi-bot Bot commented Jul 8, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, windtalker, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Jul 8, 2025
@ti-chi-bot ti-chi-bot Bot merged commit 1cbda98 into pingcap:master Jul 8, 2025
26 of 27 checks passed
breezewish added a commit to breezewish/tidb that referenced this pull request Jul 9, 2025
@breezewish
Merge commit '5ec4f36c855574b64be98e4c9f6b4485ceb4143d' into wenxuan/…
00f1ba5 
…fix-scalar-func-init

* commit '5ec4f36c855574b64be98e4c9f6b4485ceb4143d': (48 commits)
  dxf: use correct store in add-index, checksum by copr in import-into, and enable DXF service (pingcap#62224)
  infoschema: Add new fields in tiflash system table (pingcap#62296)
  lightning: fix panic on checksum manager close when checksum is off (pingcap#62300)
  *: Add owners cfg file for pkg/metrics module (pingcap#62292)
  autoid: reserve a table ID range for downstream fork (pingcap#62157)
  planner: Fix expression rewriting and method signature mismatch in plan cache (pingcap#58506)
  planner: use prop based noCopPushDown mechanism to replace aggregation field. (pingcap#62249)
  fix: close issue 59457 by trim compare first (pingcap#61915)
  planner: add skew risk ratio for range pred (pingcap#62035)
  meta: unify definition of system or memory DB name (pingcap#62247)
  ddl: add retry for updateSelfVersion (pingcap#62190)
  *: upgrade client go to add config valid function (pingcap#62246)
  executor: fix the inappropriate RequiredRows set by `TopNExec` (pingcap#62154)
  planner: RegardNULLAsPoint should be true as default (pingcap#62194)
  planner: apply predicate simplification before extract condition (pingcap#62211)
  test: fix failed test caused by new version of `mc` (pingcap#61356)
  planner: deprecate the logical interface CanPushToCop and its implementation canPushToCopImpl. (pingcap#62235)
  fix: shut down test without error (pingcap#61921)
  planner: lift the canPushToCop check of logical join/window/selection (pingcap#62206)
  backend/local: add rate limiter for split region and ingest data (pingcap#61555)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lance6716 lance6716 lance6716 approved these changes
@windtalker windtalker windtalker approved these changes
@YangKeao YangKeao YangKeao approved these changes
@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees

@windtalker windtalker

Labels

approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

IS_UUID and UUID_TO_BIN shouldn't trim the argument

4 participants

@yihong0618 @lance6716 @windtalker @YangKeao