domain: decouple info schema syncer#61794
Conversation
ti-chi-bot
Bot
added
do-not-merge/work-in-progress
|
Hi @D3Hunter. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #61794 +/- ##
================================================
+ Coverage 73.0660% 75.2905% +2.2245%
================================================
Files 1730 1781 +51
Lines 481492 493403 +11911
================================================
+ Hits 351807 371486 +19679
+ Misses 108156 98923 -9233
- Partials 21529 22994 +1465
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
| } | ||
| } | ||
|
|
||
| func TestDeferFn(t *testing.T) { |
There was a problem hiding this comment.
moved to pkg/infoschema/issyncer/
| var tblIDs []int64 | ||
| var actionTypes []uint64 | ||
| if change != nil { | ||
| tblIDs = change.PhyTblIDS | ||
| actionTypes = change.ActionTypes | ||
| } | ||
| for idx, ac := range actionTypes { |
There was a problem hiding this comment.
moved to where Update is called to decouple it from infoSyncer, see issyncer.Syncer.postReload
| logutil.BgLogger().Error("domain is closed, exit info schema sync loop") | ||
| return | ||
| } | ||
| s.schemaValidator.Restart(s.InfoSchema().SchemaMetaVersion()) |
There was a problem hiding this comment.
we are passing the schema version to decouple validator from infoschema syncer
D3Hunter
changed the title
ti-chi-bot
Bot
removed
the
do-not-merge/work-in-progress
ti-chi-bot
Bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Leavrth, tangenta, tiancaiamao The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4 participants
What problem does this PR solve?
Issue Number: ref #61702
Problem Summary:
What changed and how does it work?
in nextgen, we need to access system tables of SYSTEM keyspace from user keyspace, and need to load its schema to make sure we can use correct row ID allocator when do insert. this PR is the first part to impl it.
most part are moving and abstracting code, see comments for where logic are change
isin the code is the abbr forinfo schemaCheck List
Tests
run with real-tikv, and upgrade from older version, both success
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.