Skip to content

dxf: add keyspace name to global task table#61755

Merged
ti-chi-bot[bot] merged 2 commits into
pingcap:masterfrom
D3Hunter:dxf-service-table-schema
Jun 18, 2025
Merged

dxf: add keyspace name to global task table#61755
ti-chi-bot[bot] merged 2 commits into
pingcap:masterfrom
D3Hunter:dxf-service-table-schema

Conversation

@D3Hunter

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: ref #61702

Problem Summary:

What changed and how does it work?

as title, and we use keyspace name of current instance as the task keyspace

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

bootstrap a new cluster with PR, check table schema correct. also test with a upgrade scenario, all success

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 16, 2025
@tiprow

tiprow Bot commented Jun 16, 2025

Copy link
Copy Markdown

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov

codecov Bot commented Jun 16, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.2400%. Comparing base (5343560) to head (162a8db).
Report is 17 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #61755        +/-   ##
================================================
+ Coverage   73.0870%   75.2400%   +2.1530%     
================================================
  Files          1730       1746        +16     
  Lines        481184     485352      +4168     
================================================
+ Hits         351683     365179     +13496     
+ Misses       107956      97977      -9979     
- Partials      21545      22196       +651     
Flag Coverage Δ
integration 46.6289% <0.0000%> (?)
unit 72.6903% <86.3636%> (+0.3622%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7804% <ø> (ø)
parser ∅ <ø> (∅)
br 64.3804% <ø> (+17.4054%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Benjamin2037 Benjamin2037 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 18, 2025
@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 18, 2025
@ti-chi-bot

ti-chi-bot Bot commented Jun 18, 2025

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2025-06-18 02:47:49.99369946 +0000 UTC m=+239922.716878439: ☑️ agreed by Benjamin2037.
  • 2025-06-18 08:29:08.540802897 +0000 UTC m=+260401.263981945: ☑️ agreed by wjhuang2016.

@3pointer

Copy link
Copy Markdown
Contributor

tidb_global_task is unrecoverable table.

@yudongusa yudongusa left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also open a document PR

@ti-chi-bot

ti-chi-bot Bot commented Jun 18, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, Benjamin2037, wjhuang2016, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Jun 18, 2025
@ti-chi-bot ti-chi-bot Bot merged commit 8e6d77a into pingcap:master Jun 18, 2025
31 of 33 checks passed
@D3Hunter D3Hunter deleted the dxf-service-table-schema branch June 19, 2025 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants