dxf: make target scope fixed to dxf_service on nextgen#61427
Conversation
|
Hi @D3Hunter. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #61427 +/- ##
================================================
+ Coverage 73.2396% 75.4914% +2.2518%
================================================
Files 1726 1751 +25
Lines 479470 494256 +14786
================================================
+ Hits 351162 373121 +21959
+ Misses 106828 98197 -8631
- Partials 21480 22938 +1458
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
/retest |
|
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[LGTM Timeline notifier]Timeline:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, GMHDBJD, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@D3Hunter: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest |
|
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What problem does this PR solve?
Issue Number: ref #60418
Problem Summary:
What changed and how does it work?
DXF have a compatibility logic for
backgroundscope, DXF will try schedule tasks with target scope equals to default scope(i.e. empty scope) to nodes withbackgroundscope if there are anybackgroundnodes, but if there are no such nodes, DXF will schedule those tasks on nodes with default scope which also runs heavy user workload, that's not expected, as we want to separate user workload and DXF related workload completely on tidb side on nextgen. to avoid this issue, we make target scope of tasks fixed todxf_serviceon nextgen.Check List
Tests
run a nextgen cluster with default scope, then start import into job. this job will be blocked as we don't have node with scope
dxf_service. then we set one tidb scope todxf_service, then the import run and succeed.Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.