Skip to content

dxf: make target scope fixed to dxf_service on nextgen#61427

Merged
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
D3Hunter:nextgen-target-scope
Jun 4, 2025
Merged

dxf: make target scope fixed to dxf_service on nextgen#61427
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
D3Hunter:nextgen-target-scope

Conversation

@D3Hunter

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: ref #60418

Problem Summary:

What changed and how does it work?

DXF have a compatibility logic for background scope, DXF will try schedule tasks with target scope equals to default scope(i.e. empty scope) to nodes with background scope if there are any background nodes, but if there are no such nodes, DXF will schedule those tasks on nodes with default scope which also runs heavy user workload, that's not expected, as we want to separate user workload and DXF related workload completely on tidb side on nextgen. to avoid this issue, we make target scope of tasks fixed to dxf_service on nextgen.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

run a nextgen cluster with default scope, then start import into job. this job will be blocked as we don't have node with scope dxf_service. then we set one tidb scope to dxf_service, then the import run and succeed.

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 30, 2025
@tiprow

tiprow Bot commented May 30, 2025

Copy link
Copy Markdown

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov

codecov Bot commented May 30, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.4914%. Comparing base (cfac545) to head (9e260dd).
Report is 28 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #61427        +/-   ##
================================================
+ Coverage   73.2396%   75.4914%   +2.2518%     
================================================
  Files          1726       1751        +25     
  Lines        479470     494256     +14786     
================================================
+ Hits         351162     373121     +21959     
+ Misses       106828      98197      -8631     
- Partials      21480      22938      +1458     
Flag Coverage Δ
integration 49.6101% <33.3333%> (?)
unit 72.6848% <66.6666%> (+0.1916%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7804% <ø> (ø)
parser ∅ <ø> (∅)
br 65.9501% <ø> (+18.3344%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@D3Hunter

Copy link
Copy Markdown
Contributor Author

/retest

@tiprow

tiprow Bot commented May 30, 2025

Copy link
Copy Markdown

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot Bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 3, 2025

@Benjamin2037 Benjamin2037 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 4, 2025
@ti-chi-bot

ti-chi-bot Bot commented Jun 4, 2025

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2025-06-03 11:47:23.364801503 +0000 UTC m=+355929.567146768: ☑️ agreed by GMHDBJD.
  • 2025-06-04 03:38:27.519974801 +0000 UTC m=+412993.722320065: ☑️ agreed by Benjamin2037.

@ti-chi-bot

ti-chi-bot Bot commented Jun 4, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, GMHDBJD, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@D3Hunter

D3Hunter commented Jun 4, 2025

Copy link
Copy Markdown
Contributor Author

/retest

@tiprow

tiprow Bot commented Jun 4, 2025

Copy link
Copy Markdown

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot

ti-chi-bot Bot commented Jun 4, 2025

Copy link
Copy Markdown

@D3Hunter: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test 9e260dd link unknown /test unit-test
pull-unit-test-ddlv1 9e260dd link unknown /test pull-unit-test-ddlv1

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@D3Hunter

D3Hunter commented Jun 4, 2025

Copy link
Copy Markdown
Contributor Author

/retest

@tiprow

tiprow Bot commented Jun 4, 2025

Copy link
Copy Markdown

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot Bot merged commit c1a4550 into pingcap:master Jun 4, 2025
23 of 27 checks passed
@D3Hunter D3Hunter deleted the nextgen-target-scope branch June 4, 2025 06:54
joechenrh pushed a commit to joechenrh/tidb that referenced this pull request Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants