Skip to content

*: prepare for real-tikv-test on next gen#60892

Merged
ti-chi-bot[bot] merged 2 commits into
pingcap:masterfrom
D3Hunter:next-gen-ci
Apr 28, 2025
Merged

*: prepare for real-tikv-test on next gen#60892
ti-chi-bot[bot] merged 2 commits into
pingcap:masterfrom
D3Hunter:next-gen-ci

Conversation

@D3Hunter

@D3Hunter D3Hunter commented Apr 28, 2025

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: ref #60418

Problem Summary:

What changed and how does it work?

use the same NEXT_GEN=1 to control next gen real-tikv test

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

see the define gotags= part

➜  tidb git:(one-writer-ondup) ✗ make --dry-run bazel_importintotest3
GOBIN=/Users/jujiajia/code/pingcap/tidb/tools/bin GO111MODULE=on go install github.com/pingcap/failpoint/failpoint-ctl@9b3b6e3
find $PWD/ -mindepth 1 -type d | grep -vE "(\.git|\.idea|tools)" | xargs tools/bin/failpoint-ctl enable
bazel  run  //:gazelle
bazel  run   \
	--run_under="cd /Users/jujiajia/code/pingcap/tidb && " \
	 //tools/tazel:tazel
bazel  test  --test_output=all --test_arg=-with-real-tikv --define gotags=deadlock,intest \
	-- //tests/realtikvtest/importintotest3/...

➜  tidb git:(one-writer-ondup) ✗ NEXT_GEN=1 make --dry-run bazel_importintotest3
GOBIN=/Users/jujiajia/code/pingcap/tidb/tools/bin GO111MODULE=on go install github.com/pingcap/failpoint/failpoint-ctl@9b3b6e3
find $PWD/ -mindepth 1 -type d | grep -vE "(\.git|\.idea|tools)" | xargs tools/bin/failpoint-ctl enable
bazel  run  //:gazelle
bazel  run   \
	--run_under="cd /Users/jujiajia/code/pingcap/tidb && " \
	 //tools/tazel:tazel
bazel  test  --test_output=all --test_arg=-with-real-tikv --define gotags=deadlock,intest,nextgen \
	-- //tests/realtikvtest/importintotest3/...
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 28, 2025
@tiprow

tiprow Bot commented Apr 28, 2025

Copy link
Copy Markdown

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov

codecov Bot commented Apr 28, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.5435%. Comparing base (d5b1f58) to head (498d490).
Report is 3 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #60892        +/-   ##
================================================
+ Coverage   73.1364%   73.5435%   +0.4071%     
================================================
  Files          1722       1722                
  Lines        476542     476580        +38     
================================================
+ Hits         348526     350494      +1968     
+ Misses       106616     104692      -1924     
+ Partials      21400      21394         -6     
Flag Coverage Δ
integration 42.5727% <ø> (?)
unit 72.3568% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7118% <ø> (ø)
parser ∅ <ø> (∅)
br 47.3515% <ø> (+0.0082%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot Bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 28, 2025

@Benjamin2037 Benjamin2037 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 28, 2025
@ti-chi-bot

ti-chi-bot Bot commented Apr 28, 2025

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2025-04-28 08:04:26.340893705 +0000 UTC m=+861210.152684086: ☑️ agreed by hawkingrei.
  • 2025-04-28 09:18:35.132756685 +0000 UTC m=+865658.944547065: ☑️ agreed by Benjamin2037.

@ti-chi-bot

ti-chi-bot Bot commented Apr 28, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, hawkingrei, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [Benjamin2037,hawkingrei,tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot merged commit c4b0e60 into pingcap:master Apr 28, 2025
@D3Hunter D3Hunter deleted the next-gen-ci branch April 28, 2025 10:52
Kiran01bm pushed a commit to Kiran01bm/tidb that referenced this pull request Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants