build: use makefile flag to control next gen build by D3Hunter · Pull Request #60510 · pingcap/tidb

D3Hunter · 2025-04-11T09:25:24Z

What problem does this PR solve?

Issue Number: ref #60418

Problem Summary:

What changed and how does it work?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)

➜  tidb git:(build-option) ✗ NEXT_GEN=1 make server

➜  tidb git:(build-option) ✗ bin/tidb-server -V
Release Version: v9.0.0-alpha-506-gc7d7a967f4-dirty
Edition: Community
Git Commit Hash: c7d7a967f4833a3989d5c98d37d26c6c6dda7b93
Git Branch: build-option
UTC Build Time: 2025-04-11 09:19:10
GoVersion: go1.23.8
Race Enabled: false
Check Table Before Drop: false
Store: unistore
Cloud Store: true

➜  tidb git:(build-option) ✗ make server

➜  tidb git:(build-option) ✗ bin/tidb-server -V
Release Version: v9.0.0-alpha-506-gc7d7a967f4-dirty
Edition: Community
Git Commit Hash: c7d7a967f4833a3989d5c98d37d26c6c6dda7b93
Git Branch: build-option
UTC Build Time: 2025-04-11 09:21:46
GoVersion: go1.23.8
Race Enabled: false
Check Table Before Drop: false
Store: unistore

No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

tiprow · 2025-04-11T09:25:42Z

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

D3Hunter · 2025-04-11T09:31:46Z

/retest

tiprow · 2025-04-11T09:32:08Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

codecov · 2025-04-11T09:46:43Z

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (feature/ng-tidb@c7d7a96). Learn more about missing BASE report.

Additional details and impacted files

@@                 Coverage Diff                  @@
##             feature/ng-tidb     #60510   +/-   ##
====================================================
  Coverage                   ?   73.5290%           
====================================================
  Files                      ?       1711           
  Lines                      ?     473123           
  Branches                   ?          0           
====================================================
  Hits                       ?     347883           
  Misses                     ?     103983           
  Partials                   ?      21257

Flag	Coverage Δ
integration	`42.9305% <40.0000%> (?)`
unit	`72.3725% <40.0000%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.6910% <0.0000%> (?)`
parser	`∅ <0.0000%> (?)`
br	`47.2284% <0.0000%> (?)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

purelind · 2025-04-11T10:02:11Z

/retest

tiprow · 2025-04-11T10:02:34Z

@purelind: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Benjamin2037

LGTM

lance6716 · 2025-04-14T04:22:57Z

 		enterpriseVersion,
 	)
+	if config.IsCloudStore() {
+		info += "\nNext Generation"


the output is a bit different with other line as the format {name}: {value}

Next Generation: {some API version}

is better?

maybe Cloud Store: true?

i will check with PM when merge to master later

lance6716 · 2025-04-14T04:31:42Z

/lgtm
/hold

free to unhold

ti-chi-bot · 2025-04-14T04:31:50Z

[LGTM Timeline notifier]

Timeline:

2025-04-14 03:49:49.755570626 +0000 UTC m=+2660283.439806735: ☑️ agreed by Benjamin2037.
2025-04-14 04:31:50.100374548 +0000 UTC m=+2662803.784610641: ☑️ agreed by lance6716.

ti-chi-bot · 2025-04-14T04:31:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [Benjamin2037,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

D3Hunter · 2025-04-14T04:34:00Z

/unhold

D3Hunter · 2025-04-14T05:48:00Z

/retest

tiprow · 2025-04-14T05:48:23Z

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ref pingcap#60418

change

02d575e

ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 11, 2025

D3Hunter changed the base branch from master to feature/ng-tidb April 11, 2025 09:25

ti-chi-bot Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 11, 2025

Benjamin2037 approved these changes Apr 14, 2025

View reviewed changes

ti-chi-bot Bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 14, 2025

lance6716 reviewed Apr 14, 2025

View reviewed changes

ti-chi-bot Bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 14, 2025

D3Hunter commented Apr 14, 2025

View reviewed changes

Comment thread pkg/util/printer/printer.go Outdated

Update pkg/util/printer/printer.go

42951a7

ti-chi-bot Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 14, 2025

ti-chi-bot Bot merged commit 9a688e1 into pingcap:feature/ng-tidb Apr 14, 2025

D3Hunter deleted the build-option branch April 14, 2025 06:26

D3Hunter added a commit to D3Hunter/tidb that referenced this pull request Apr 18, 2025

build: use makefile flag to control next gen build (pingcap#60510)

b482ab7

ref pingcap#60418

D3Hunter mentioned this pull request Jun 12, 2025

add-index/import-into on global sort for next generation TiDB #60418

Closed

29 tasks

Uh oh!

Conversation

D3Hunter commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

Uh oh!

tiprow Bot commented Apr 11, 2025

Uh oh!

D3Hunter commented Apr 11, 2025

Uh oh!

tiprow Bot commented Apr 11, 2025

Uh oh!

codecov Bot commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

purelind commented Apr 11, 2025

Uh oh!

tiprow Bot commented Apr 11, 2025

Uh oh!

Benjamin2037 left a comment

Choose a reason for hiding this comment

Uh oh!

lance6716 Apr 14, 2025

Choose a reason for hiding this comment

Uh oh!

D3Hunter Apr 14, 2025

Choose a reason for hiding this comment

Uh oh!

lance6716 commented Apr 14, 2025

Uh oh!

ti-chi-bot Bot commented Apr 14, 2025

[LGTM Timeline notifier]

Uh oh!

ti-chi-bot Bot commented Apr 14, 2025

Uh oh!

Uh oh!

D3Hunter commented Apr 14, 2025

Uh oh!

D3Hunter commented Apr 14, 2025

Uh oh!

tiprow Bot commented Apr 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

D3Hunter commented Apr 11, 2025 •

edited

Loading

codecov Bot commented Apr 11, 2025 •

edited

Loading