Skip to content

infoschema,metrics: use tidb_tikvclient_request_seconds_bucket to get the .999 cop req duration instead (#59845)#60394

Merged
ti-chi-bot[bot] merged 6 commits intopingcap:release-8.5from
ti-chi-bot:cherry-pick-59845-to-release-8.5
Jul 11, 2025
Merged

infoschema,metrics: use tidb_tikvclient_request_seconds_bucket to get the .999 cop req duration instead (#59845)#60394
ti-chi-bot[bot] merged 6 commits intopingcap:release-8.5from
ti-chi-bot:cherry-pick-59845-to-release-8.5

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #59845

What problem does this PR solve?

Issue Number: Ref #59815

Problem Summary:
The TiDB -> Distsql -> Coprocessor Seconds 999 panel uses the tidb_tikvclient_cop_duration_seconds_bucket metric to gather data, but this metric is redundant. We can use tidb_tikvclient_request_seconds_bucket to obtain the same data. Therefore, tidb_tikvclient_cop_duration_seconds_bucket can be removed to save storage space.

client-go PR tikv/client-go#1602

What changed and how does it work?

Before:
截屏2025-02-27 17 02 53

After:
截屏2025-02-27 17 02 39

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Apr 3, 2025
@codecov
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-8.5@7294dfb). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.5     #60394   +/-   ##
================================================
  Coverage               ?   57.7740%           
================================================
  Files                  ?       1777           
  Lines                  ?     631586           
  Branches               ?          0           
================================================
  Hits                   ?     364893           
  Misses                 ?     242131           
  Partials               ?      24562           
Flag Coverage Δ
integration 38.4087% <ø> (?)
unit 72.7965% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9278% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 64.2751% <0.0000%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 9, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 9, 2025

@zimulala: Your lgtm message is repeated, so it is ignored.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 9, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 9, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-07-09 09:07:26.185141581 +0000 UTC m=+2077098.908320563: ☑️ agreed by zimulala.
  • 2025-07-09 10:12:41.618359353 +0000 UTC m=+2081014.341538320: ☑️ agreed by yibin87.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jul 9, 2025
@XuHuaiyu
Copy link
Contributor

/run-tests

@XuHuaiyu
Copy link
Contributor

/run-check_dev_2

@XuHuaiyu
Copy link
Contributor

/run-unit-test

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, yibin87, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 11, 2025
@ti-chi-bot ti-chi-bot bot merged commit c4f403d into pingcap:release-8.5 Jul 11, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants