Skip to content

infoschema,metrics: use tidb_tikvclient_request_seconds_bucket to get the .999 cop req duration instead (#59845)#60392

Open
ti-chi-bot wants to merge 4 commits intopingcap:release-8.1from
ti-chi-bot:cherry-pick-59845-to-release-8.1
Open

infoschema,metrics: use tidb_tikvclient_request_seconds_bucket to get the .999 cop req duration instead (#59845)#60392
ti-chi-bot wants to merge 4 commits intopingcap:release-8.1from
ti-chi-bot:cherry-pick-59845-to-release-8.1

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #59845

What problem does this PR solve?

Issue Number: Ref #59815

Problem Summary:
The TiDB -> Distsql -> Coprocessor Seconds 999 panel uses the tidb_tikvclient_cop_duration_seconds_bucket metric to gather data, but this metric is redundant. We can use tidb_tikvclient_request_seconds_bucket to obtain the same data. Therefore, tidb_tikvclient_cop_duration_seconds_bucket can be removed to save storage space.

client-go PR tikv/client-go#1602

What changed and how does it work?

Before:
截屏2025-02-27 17 02 53

After:
截屏2025-02-27 17 02 39

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Apr 3, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign benjamin2037 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 3, 2025

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/mysql-test 82008bc link true /test mysql-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-8.1@9325eee). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #60392   +/-   ##
================================================
  Coverage               ?   71.2091%           
================================================
  Files                  ?       1468           
  Lines                  ?     424038           
  Branches               ?          0           
================================================
  Hits                   ?     301954           
  Misses                 ?     101534           
  Partials               ?      20550           
Flag Coverage Δ
unit 71.2091% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.4206% <0.0000%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants