infoschema,metrics: use tidb_tikvclient_request_seconds_bucket to get the .999 cop req duration instead (#59845)#60392
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@ti-chi-bot: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #60392 +/- ##
================================================
Coverage ? 71.2091%
================================================
Files ? 1468
Lines ? 424038
Branches ? 0
================================================
Hits ? 301954
Misses ? 101534
Partials ? 20550
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This is an automated cherry-pick of #59845
What problem does this PR solve?
Issue Number: Ref #59815
Problem Summary:
The
TiDB -> Distsql -> Coprocessor Seconds 999panel uses thetidb_tikvclient_cop_duration_seconds_bucketmetric to gather data, but this metric is redundant. We can usetidb_tikvclient_request_seconds_bucketto obtain the same data. Therefore,tidb_tikvclient_cop_duration_seconds_bucketcan be removed to save storage space.client-go PR tikv/client-go#1602
What changed and how does it work?
Before:

After:

Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.