infoschema,metrics: use tidb_tikvclient_request_seconds_bucket to get the .999 cop req duration instead (#59845)#60390
Merged
ti-chi-bot[bot] merged 5 commits intopingcap:release-7.5from Jul 21, 2025
Conversation
13 tasks
MyonKeminta
approved these changes
Jul 21, 2025
zimulala
approved these changes
Jul 21, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MyonKeminta, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Contributor
|
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #60390 +/- ##
================================================
Coverage ? 72.1880%
================================================
Files ? 1421
Lines ? 414936
Branches ? 0
================================================
Hits ? 299534
Misses ? 95368
Partials ? 20034
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #59845
What problem does this PR solve?
Issue Number: Ref #59815
Problem Summary:
The
TiDB -> Distsql -> Coprocessor Seconds 999panel uses thetidb_tikvclient_cop_duration_seconds_bucketmetric to gather data, but this metric is redundant. We can usetidb_tikvclient_request_seconds_bucketto obtain the same data. Therefore,tidb_tikvclient_cop_duration_seconds_bucketcan be removed to save storage space.client-go PR tikv/client-go#1602
What changed and how does it work?
Before:

After:

Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.