Skip to content

privileges: user@'' is different with user@'%' | tidb-test=pr/2498#60082

Merged
ti-chi-bot[bot] merged 3 commits into
pingcap:masterfrom
Defined2014:fix33174
Mar 17, 2025
Merged

privileges: user@'' is different with user@'%' | tidb-test=pr/2498#60082
ti-chi-bot[bot] merged 3 commits into
pingcap:masterfrom
Defined2014:fix33174

Conversation

@Defined2014

@Defined2014 Defined2014 commented Mar 14, 2025

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #33174

Problem Summary:
Previously, user@'' consider equals to user@'%' when performing operations related to set default role.

What changed and how does it work?

Check List

Tests

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix `set default role` failed with empty hostname user.

@ti-chi-bot ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 14, 2025
@Defined2014 Defined2014 changed the title privileges: user@'' is different with user@'%' privileges: user@'' is different with user@'%' Mar 14, 2025
@tiprow

tiprow Bot commented Mar 14, 2025

Copy link
Copy Markdown

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Defined2014 Defined2014 added the compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. label Mar 14, 2025
@ti-chi-bot ti-chi-bot Bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 14, 2025
@codecov

codecov Bot commented Mar 14, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 73.7758%. Comparing base (2f55858) to head (a18bb7f).
Report is 7 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #60082        +/-   ##
================================================
+ Coverage   73.1646%   73.7758%   +0.6112%     
================================================
  Files          1706       1706                
  Lines        471381     472572      +1191     
================================================
+ Hits         344884     348644      +3760     
+ Misses       105302     102809      -2493     
+ Partials      21195      21119        -76     
Flag Coverage Δ
integration 42.9774% <0.0000%> (?)
unit 72.5905% <0.0000%> (+0.2266%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 47.2618% <ø> (+0.0378%) ⬆️
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Defined2014

Copy link
Copy Markdown
Contributor Author

/retest

@tiprow

tiprow Bot commented Mar 14, 2025

Copy link
Copy Markdown

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Defined2014 Defined2014 changed the title privileges: user@'' is different with user@'%' privileges: user@'' is different with user@'%' | tidb-test=pr/2498 Mar 14, 2025
@Defined2014 Defined2014 removed the compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. label Mar 14, 2025
@Defined2014

Copy link
Copy Markdown
Contributor Author

/retest

@tiprow

tiprow Bot commented Mar 14, 2025

Copy link
Copy Markdown

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Defined2014 Defined2014 requested a review from zimulala March 14, 2025 08:38
@ti-chi-bot ti-chi-bot Bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 16, 2025
@ti-chi-bot

ti-chi-bot Bot commented Mar 17, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, tiancaiamao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [lance6716,tiancaiamao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 17, 2025
@ti-chi-bot

ti-chi-bot Bot commented Mar 17, 2025

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2025-03-16 10:33:29.670360246 +0000 UTC m=+178903.354596327: ☑️ agreed by lance6716.
  • 2025-03-17 02:26:48.430717107 +0000 UTC m=+236102.114953202: ☑️ agreed by tiancaiamao.

@ti-chi-bot ti-chi-bot Bot merged commit d22abc8 into pingcap:master Mar 17, 2025
@Defined2014 Defined2014 deleted the fix33174 branch March 17, 2025 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong error on SET DEFAULT ROLE with empty hostnames

3 participants