*: avoid some unnecessary call of ensureActiveUser() (#57388)#59803
*: avoid some unnecessary call of ensureActiveUser() (#57388)#59803ti-chi-bot wants to merge 1 commit into
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
@tiancaiamao This PR has conflicts, I have hold it. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@ti-chi-bot: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
New feature don't cherry-pick to 8.5 |
This is an automated cherry-pick of #57388
What problem does this PR solve?
Issue Number: ref #55563
Problem Summary:
What changed and how does it work?
In #57042, I add too much calls of
ensureActiveUser()than necessary. That's introduced to make the CI pass.That PR had already done a lot to make the CI pass .... So I don't like to introduce extra complexity to it.
After merge that, this commit will be used to reduce some unnecessary
ensureActiveUser().Check List
Tests
For example
Without optimizing the unnecessary
ensureActiveUser(), If I useset password for user%dto change password for 2M users, here is the QPSAfter the optimization:
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.