privilege: handle username with "@" correctly for role(RBAC) related code#59739
Conversation
|
Hi @tiancaiamao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #59739 +/- ##
================================================
+ Coverage 72.9611% 73.4831% +0.5219%
================================================
Files 1697 1699 +2
Lines 468962 469633 +671
================================================
+ Hits 342160 345101 +2941
+ Misses 105734 103513 -2221
+ Partials 21068 21019 -49
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/test check-dev2 |
|
@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #59552
Problem Summary:
What changed and how does it work?
The old code use key = username + "@" + host, and also split by "@" to get back the username.
This is not stable enough when the username itself contains "@"
Change key from username + "@" + host to {username, host} struct makes the code more robust.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.