expression: avoid slicesgrow in the extractBinaryOpItems #59320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note-none
XuHuaiyu
approved these changes
Feb 7, 2025
ti-chi-bot
bot
added
needs-1-more-lgtm
hawkingrei
commented
Feb 7, 2025
| @@ -821,7 +821,7 @@ func ComposeDNFCondition(ctx BuildContext, conditions ...Expression) Expression | |||
| } | |||
|
|
|||
| func extractBinaryOpItems(conditions *ScalarFunction, funcName string) []Expression { | |||
| var ret []Expression | |||
| ret := make([]Expression, 0, len(conditions.GetArgs())) | |||
There was a problem hiding this comment.
Although it cannot be completely eliminated, it is better than nothing.
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XuHuaiyu, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #59320 +/- ##
================================================
+ Coverage 73.0474% 73.4768% +0.4293%
================================================
Files 1689 1690 +1
Lines 467010 467391 +381
================================================
+ Hits 341139 343424 +2285
+ Misses 104891 102988 -1903
+ Partials 20980 20979 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #59319
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.