Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sessionctx, executor, infoschema: Add fine grained network traffic stats in slow log #59041

Merged
merged 9 commits into from
Jan 22, 2025
Merged

sessionctx, executor, infoschema: Add fine grained network traffic stats in slow log #59041

merged 9 commits into from
Jan 22, 2025

Conversation

yibin87
Copy link
Contributor

@yibin87 yibin87 commented Jan 20, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #57543

Problem Summary:

What changed and how does it work?

  1. In util/stmtsummary: add the network traffic related fields #58101, fine grained traffic stats are added in statements summary. In this PR, these stats are added in slow query log.
  2. Optimize the usage for using tikvExecDetails in stats loging, because the struct value has been copied already, no need to use atomic load anymore.

After the PR, the slow_query table schema will add 8 new columns, adding about 340 bytes for default values to one slow query log:
img_v3_02io_c4eb65ed-fb1e-47bd-95c5-b29b6903e78g

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 20, 2025
@tiprow tiprow
Copy link

tiprow bot commented Jan 20, 2025

Hi @yibin87. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@yibin87
Copy link
Contributor Author

yibin87 commented Jan 20, 2025

/cc @nolouch @songrijie

@ti-chi-bot ti-chi-bot bot requested review from nolouch and songrijie January 20, 2025 06:59
@codecov Codecov
Copy link

codecov bot commented Jan 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.9894%. Comparing base (c34a6b6) to head (7e20086).
Report is 16 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #59041        +/-   ##
================================================
+ Coverage   72.9965%   74.9894%   +1.9928%     
================================================
  Files          1683       1729        +46     
  Lines        465963     476202     +10239     
================================================
+ Hits         340137     357101     +16964     
+ Misses       104867      96688      -8179     
- Partials      20959      22413      +1454
Flag Coverage Δ
integration 48.9051% <48.2758%> (?)
unit 72.3898% <100.0000%> (+0.2068%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 60.9798% <ø> (+15.6687%) ⬆️

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 20, 2025
@yibin87 yibin87 mentioned this pull request Jan 20, 2025
Merged
13 tasks
@yibin87
Copy link
Contributor Author

yibin87 commented Jan 20, 2025

/test unit-test

@tiprow tiprow
Copy link

tiprow bot commented Jan 20, 2025

@yibin87: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

nolouch
nolouch reviewed Jan 20, 2025
View reviewed changes
pkg/sessionctx/variable/session.go Outdated
writeSlowLogItem(&buf, SlowLogUnpackedBytesReceivedKVTotal, strconv.FormatInt(logItems.KVExecDetail.UnpackedBytesReceivedKVTotal, 10))
writeSlowLogItem(&buf, SlowLogUnpackedBytesSentKVCrossZone, strconv.FormatInt(logItems.KVExecDetail.UnpackedBytesSentKVCrossZone, 10))
writeSlowLogItem(&buf, SlowLogUnpackedBytesReceivedKVCrossZone, strconv.FormatInt(logItems.KVExecDetail.UnpackedBytesReceivedKVCrossZone, 10))
writeSlowLogItem(&buf, SlowLogUnpackedBytesSentMPPTotal, strconv.FormatInt(logItems.KVExecDetail.UnpackedBytesSentMPPTotal, 10))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we omit the log if the field is 0?

Copy link
Contributor Author

@yibin87 yibin87 Jan 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's your option, Roger? @songrijie

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd better not to omit it, if there is no strong reason.

@yibin87
Add fine grained network traffic stats in slow log
7ca518c 
Signed-off-by: yibin87 <huyibin@pingcap.com>
@yibin87
Little update
3ba1191 
Signed-off-by: yibin87 <huyibin@pingcap.com>
@yibin87
update statements summary test
534b8c7 
Signed-off-by: yibin87 <huyibin@pingcap.com>
@yibin87
Fix test usage
2a02b33 
Signed-off-by: yibin87 <huyibin@pingcap.com>
@yibin87
fix utest failure
ea733c7 
Signed-off-by: yibin87 <huyibin@pingcap.com>
@yibin87 yibin87 force-pushed the update_network_slowlog branch from 609ef65 to ea733c7 Compare January 21, 2025 03:10
@yibin87
Copy link
Contributor Author

yibin87 commented Jan 21, 2025

/cc @tangenta

@ti-chi-bot ti-chi-bot bot requested a review from tangenta January 21, 2025 03:21
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 21, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 21, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 21, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-21 03:31:24.746992986 +0000 UTC m=+151612.077912387: ☑️ agreed by tangenta.
  • 2025-01-21 07:19:39.614659597 +0000 UTC m=+165306.945579000: ☑️ agreed by nolouch.

@yibin87
change names from mpp to tiflash
93f22ff 
Signed-off-by: yibin87 <huyibin@pingcap.com>
@yibin87
Little update
5126fc1 
Signed-off-by: yibin87 <huyibin@pingcap.com>
@yibin87
Fix lint issue
4d1eb81 
Signed-off-by: yibin87 <huyibin@pingcap.com>
@yibin87
update kv to tikv
7e20086 
Signed-off-by: yibin87 <huyibin@pingcap.com>
@yibin87
Copy link
Contributor Author

yibin87 commented Jan 21, 2025

/test pull-br-integration-test

@tiprow tiprow
Copy link

tiprow bot commented Jan 21, 2025

@yibin87: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nolouch, tangenta, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 22, 2025
@ti-chi-bot ti-chi-bot bot merged commit 51d723b into pingcap:master Jan 22, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yudongusa yudongusa yudongusa approved these changes

@tangenta tangenta tangenta approved these changes

@nolouch nolouch nolouch approved these changes

@songrijie songrijie Awaiting requested review from songrijie

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yibin87 @nolouch @songrijie @tangenta @yudongusa