-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util: split the tests of workloadrepo into multiple shard #59030
util: split the tests of workloadrepo into multiple shard #59030
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #59030 +/- ##
================================================
+ Coverage 73.0285% 73.3223% +0.2937%
================================================
Files 1684 1685 +1
Lines 465663 467372 +1709
================================================
+ Hits 340067 342688 +2621
+ Misses 104691 103731 -960
- Partials 20905 20953 +48
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
and the running time of each test:
|
What problem does this PR solve?
Issue Number: ref #58247
Problem Summary:
What changed and how does it work?
In #58266, the timeout was set to long. From https://bazel.build/reference/test-encyclopedia, we can see that the
long
is 900s, which is too long for a whole dir.If it really has some tests exceeding the default short threshold, please verify the test first, then consider putting slow ones into a separate dir.
And enable the sharding
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.