stmtctx: re-use the usedStatsInfo for different statements in a single session
#59021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note-none
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
YangKeao
force-pushed
the
accelerate-load-stats
branch
from
a1160da to
69ff8ea
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #59021 +/- ##
================================================
+ Coverage 73.0236% 73.3665% +0.3429%
================================================
Files 1684 1684
Lines 465663 466988 +1325
================================================
+ Hits 340044 342613 +2569
+ Misses 104708 103434 -1274
- Partials 20911 20941 +30
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Very little progress, but having it is better than not. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #59019
Problem Summary:
Previously, the data in
usedStatsInfois allocated for each statements. If we can re-use it across different statements in a session, it'll benefit the performance.What changed and how does it work?
Use
(*sync.Map).Clear()to reset the map, and assign the existing map to the new stmtctx.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.