Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: add cascades wrapper for integrating cascades into current logical optimization phase. #58751

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Jan 7, 2025

What problem does this PR solve?

Issue Number: ref #51664

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

.
Signed-off-by: arenatlx <314806019@qq.com>
.
Signed-off-by: AilinKid <314806019@qq.com>
.
Signed-off-by: arenatlx <314806019@qq.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 7, 2025
Copy link

tiprow bot commented Jan 7, 2025

Hi @AilinKid. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the sig/planner SIG: Planner label Jan 7, 2025
.
Signed-off-by: arenatlx <314806019@qq.com>
.
Signed-off-by: arenatlx <314806019@qq.com>
.
Signed-off-by: arenatlx <314806019@qq.com>
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 83.14607% with 15 lines in your changes missing coverage. Please review.

Project coverage is 74.0257%. Comparing base (c199ddf) to head (f58aa60).
Report is 29 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #58751        +/-   ##
================================================
+ Coverage   73.0885%   74.0257%   +0.9372%     
================================================
  Files          1676       1679         +3     
  Lines        463643     474771     +11128     
================================================
+ Hits         338870     351453     +12583     
+ Misses       103924     101942      -1982     
- Partials      20849      21376       +527     
Flag Coverage Δ
integration 42.9064% <83.1460%> (?)
unit 72.3532% <83.1460%> (+0.0669%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.7689% <ø> (+0.0359%) ⬆️

.
Signed-off-by: arenatlx <314806019@qq.com>
Copy link

ti-chi-bot bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 9, 2025
Copy link

ti-chi-bot bot commented Jan 9, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-09 11:14:02.770056616 +0000 UTC m=+438586.058888321: ☑️ agreed by hawkingrei.

pkg/planner/cascades/cascades.go Outdated Show resolved Hide resolved
pkg/planner/cascades/cascades.go Outdated Show resolved Hide resolved
AilinKid and others added 2 commits January 10, 2025 13:10
Co-authored-by: Yiding Cui <winoros@gmail.com>
.
Signed-off-by: arenatlx <314806019@qq.com>
@AilinKid
Copy link
Contributor Author

/test unit-test

Copy link

tiprow bot commented Jan 10, 2025

@AilinKid: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@AilinKid
Copy link
Contributor Author

/test unit-test

Copy link

tiprow bot commented Jan 10, 2025

@AilinKid: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants