Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Build TiDB with PGO #58630
base: master
Are you sure you want to change the base?
*: Build TiDB with PGO #58630
Changes from 9 commits
5d091fe5405252bb45d84fa1cb8fad31bda0765a0c4e7b01f6c090db66229d17506e8ab42b50c0f75f51e8165c01949df76be639a6812abff481c606609cb85232a3a9cf548a32861653d3bd9aab5fdbbbda6a1aa024be5a0fa0a912828a63c3eaef61e738771026e6483ee982264f2f5b0cf0817357086cadfa69b8577d168cc6819402edfcff570497fcd1e9d6bf47528487File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this file will be generated by make, is it necessary to include it in git? IMO, we only need to keep either
default.pgoorbuild/profile/*.proto.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
@crazycs520 Better to also add some introduction for the choice of default.pgo like how it is generated and why it is chosen as default, which options are recommonded in different scenarios.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default.pgoneed to keep since the build plugin will use it, otherwise I may need to change other ci/build yaml of plugin.as
build/profile/*.protofiles, I also want to keep it, since one look at this folder will tell us which CPU profilesdefault.pgois currently using.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I write a test about git with large binary file, from the following test result, It wasn't really appropriate to put the profile files inside the git repo, so I've deleted them.