types,executor: treat decimal truncate as warning in update #5801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuHuaiyu
reviewed
Feb 6, 2018
executor/write_test.go
Outdated
| // A warning rather than data truncated error. | ||
| tk.MustExec("update decimals set a = a + 1.23;") | ||
| r = tk.MustQuery("select * from decimals") | ||
| r.Check(testkit.Rows("202")) |
tiancaiamao
commented
Feb 6, 2018
| _, err := tk.Exec(`select * from sc where a > cast(1.1 as decimal); | ||
| update sc set a = 4 where a > cast(1.1 as decimal)`) | ||
| c.Check(terror.ErrorEqual(err, types.ErrTruncated), IsTrue) | ||
| tk.MustExec("update sc set a = 4 where a > cast(1.1 as decimal)") |
There was a problem hiding this comment.
I've tested that this behavior confirms to MySQL 5.6, 5.7...
The previous code is wrong.
|
/run-all-tests |
|
LGTM |
zimulala
reviewed
Feb 6, 2018
| @@ -1087,8 +1087,9 @@ func ProduceDecWithSpecifiedTp(dec *MyDecimal, tp *FieldType, sc *stmtctx.Statem | |||
| return nil, errors.Trace(err) | |||
| } | |||
| if !dec.IsZero() && frac > decimal && dec.Compare(&old) != 0 { | |||
| if sc.InInsertStmt { | |||
| if sc.InInsertStmt || sc.InUpdateOrDeleteStmt { | |||
There was a problem hiding this comment.
Do we need to add a test for delete SQL?
There was a problem hiding this comment.
Delete behavior is different from MySQL:
mysql> select * from decimals;
+-----+
| a |
+-----+
| 201 |
+-----+
1 row in set (0.00 sec)
MySQL:
mysql> delete from decimals where a = cast(201.2 as decimal(20,0));
Query OK, 1 row affected (0.00 sec)
TiDB:
mysql> delete from decimals where a = cast(201.2 as decimal(20,0));
Query OK, 1 row affected, 1 warning (0.00 sec)
mysql> show warnings;
+---------+------+----------------+
| Level | Code | Message |
+---------+------+----------------+
| Warning | 1265 | Data Truncated |
+---------+------+----------------+
1 row in set (0.00 sec)
Although it's not the same behavior as MySQL, the result in this PR is more acceptable for delete statement than before.
@zimulala
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #5532
@coocood @zimulala @XuHuaiyu