Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server, metrics: move and refine server metrics #5766

Merged
merged 3 commits into from
Feb 1, 2018
Merged

server, metrics: move and refine server metrics #5766

merged 3 commits into from
Feb 1, 2018

Conversation

coocood
Copy link
Member

@coocood coocood commented Feb 1, 2018

Register the ExecutorErrorCounter which is never registered before.

@shenli
Copy link
Member

shenli commented Feb 1, 2018

LGTM

zimulala
zimulala approved these changes Feb 1, 2018
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala
Copy link
Contributor

zimulala commented Feb 1, 2018

/run-all-tests

@zimulala zimulala added the status/LGT2 Indicates that a PR has LGTM 2. label Feb 1, 2018
@shenli shenli merged commit 14a9a3d into pingcap:master Feb 1, 2018
@coocood coocood deleted the server-metrics branch February 1, 2018 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala approved these changes

Assignees
No one assigned
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coocood @shenli @zimulala