session: add index on 'user' field for mysql tables | tidb-test=pr/2430

[tiancaiamao]

What problem does this PR solve?

Issue Number: ref #55563

Problem Summary:

What changed and how does it work?

Another solution for the same purpose, see #57320
If this one is chosen, that one could be closed.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)

create new cluster and upgrade old cluster, show create table to see the result.

• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[codecov]

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.7442%. Comparing base (b079b5f) to head (d1a80bd).
Report is 356 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #57470        +/-   ##
================================================
+ Coverage   73.5301%   74.7442%   +1.2141%     
================================================
  Files          1681       1696        +15     
  Lines        464298     468650      +4352     
================================================
+ Hits         341399     350289      +8890     
+ Misses       102058      96727      -5331     
- Partials      20841      21634       +793     

Flag	Coverage Δ
integration	46.2240% <0.0000%> (?)
unit	72.2666% <72.7272%> (-0.0369%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.6910% <ø> (ø)
parser	∅ <ø> (∅)
br	61.3541% <ø> (+15.5915%)	⬆️

[D3Hunter]

rest lgtm

[tiancaiamao]

/test mysql-test

[tiprow]

@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tiancaiamao]

/test mysql-test

[tiprow]

@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tiancaiamao]

/test unit-test

[tiprow]

@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tiancaiamao]

PTAL @bb7133

[bb7133]

LGTM

[D3Hunter]

comments of 240/241 should be exchanged

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-12-26 03:57:34.528428073 +0000 UTC m=+1706844.617230616: ☑️ agreed by bb7133.
• 2024-12-26 04:05:17.93485587 +0000 UTC m=+1707308.023658412: ☑️ agreed by D3Hunter.

[tiprow]

@tiancaiamao: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
fast_test_tiprow	624934f	link	true	/test fast_test_tiprow

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, BornChanger, D3Hunter, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [BornChanger,D3Hunter,bb7133]
• br/OWNERS [BornChanger]
• pkg/session/OWNERS [yudongusa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-8.5: #59805.
But this PR has conflicts, please resolve them!