Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: ignore foreign key error in UPDATE/INSERT/DELETE ignore #56682

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

YangKeao
Copy link
Member

What problem does this PR solve?

Issue Number: close #56678, close #56681, close #39712

Problem Summary:

In the following cases, the foreign key error should be omitted and placed in the warning:

  1. INSERT IGNORE ... ON DUPLICATE UPDATE ...
  2. DELETE IGNORE ...
  3. UPDATE IGNORE ...

What changed and how does it work?

Introduce a function checkFKIgnoreErr to check rows explicitly, and use this function to check each rows in these three cases.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Oct 16, 2024
Copy link

ti-chi-bot bot commented Oct 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign winoros for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. sig/planner SIG: Planner labels Oct 16, 2024
@YangKeao YangKeao requested review from hawkingrei and removed request for lcwangchao October 16, 2024 08:26
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 64.63415% with 29 lines in your changes missing coverage. Please review.

Project coverage is 55.9010%. Comparing base (1352db6) to head (8fe6512).
Report is 1 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56682         +/-   ##
=================================================
- Coverage   73.3549%   55.9010%   -17.4539%     
=================================================
  Files          1629       1753        +124     
  Lines        450098     629142     +179044     
=================================================
+ Hits         330169     351697      +21528     
- Misses        99694     253495     +153801     
- Partials      20235      23950       +3715     
Flag Coverage Δ
integration 22.8729% <43.9024%> (?)
unit 72.4805% <64.6341%> (-0.0057%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 52.3679% <ø> (+6.7950%) ⬆️

Copy link

ti-chi-bot bot commented Oct 16, 2024

@YangKeao: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/build 8fe6512 link true /test build
idc-jenkins-ci-tidb/check_dev 8fe6512 link true /test check-dev

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

tiprow bot commented Oct 16, 2024

@YangKeao: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow 8fe6512 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
1 participant